GH-47786: [C++][FlightRPC] Establish ODBC tests #47788
Open
+893
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
reviewed
Oct 10, 2025
Comment on lines
+401
to
+379
| // TODO: once RegisterDsn is implemented in Mac and Linux, the following can be | ||
| // re-enabled. | ||
| #if defined _WIN32 || defined _WIN64 | ||
| bool WriteDSN(std::string connection_str) { |
There was a problem hiding this comment.
Could you please raise a GitHub issue for this todo?
github-actions
bot
added
awaiting committer review
alinaliBQ
reviewed
Oct 15, 2025
|
|
||
| void FlightSQLODBCRemoteTestBase::SetUp() { | ||
| if (arrow::internal::GetEnvVar(TEST_CONNECT_STR).ValueOr("").empty()) { | ||
| GTEST_SKIP() << "Skipping FlightSQLODBCRemoteTestBase test: TEST_CONNECT_STR not set"; |
There was a problem hiding this comment.
Can we change to use arrow log for this?
lidavidm
reviewed
Oct 16, 2025
github-actions
bot
added
awaiting changes
Co-Authored-By: rscales <[email protected]> Co-Authored-By: justing-bq <[email protected]> Co-Authored-By: alinalibq <[email protected]>
github-actions
bot
added
awaiting change review
alinaliBQ
reviewed
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#47786
What changes are included in this PR?
Created a new directory/subproject for tests.
Added a testing utility class called
odbc_test_suite.Created new test file with one simple test.
Are these changes tested?
Yes
Are there any user-facing changes?
No