GH-47704: [R] Update paths in nightly libarrow upload job #47727

kou · 2025-10-07T02:58:32Z

Rationale for this change

#45964 changed paths of pre-built Apache Arrow C++ binaries for R. But we forgot to update the nightly upload job.

What changes are included in this PR?

Update paths in the nightly upload job.

Are these changes tested?

No...

Are there any user-facing changes?

Yes.

GitHub Issue: [R] R nightlies not syncing to nightlies.apache.org #47704

github-actions · 2025-10-07T02:58:56Z

⚠️ GitHub issue #47704 has been automatically assigned in GitHub to PR creator.

kou · 2025-10-07T03:00:17Z

This unifies new line style (mixing CR LF and LF only -> LF only). Please use w=1, sorry: https://github.com/apache/arrow/pull/47727/files?w=1

Can we test this without merge...? Do we need to merge to main to test this...?

thisisnic

I guess to test it, we could temporarily change it to run on PRs and see if it works here, and then change back before merging? I'm not opposed to merging and seeing if it works though, given the job isn't running anyway, so it won't make anything worse.

jonkeane

I'm not opposed to merging and seeing if it works though, given the job isn't running anyway, so it won't make anything worse.

Same, I'm fine to merge this and confirm on main instead of (re)wiring to test from a branch.

jonkeane · 2025-10-07T13:45:15Z

.github/workflows/r_nightly.yml

+          done
+
+          # New packages: repo/libarrow/${TARGET}-arrow-${VERSION}.zip
+          prune repo/libarrow/r-libarrow-darwin-arm64-openssl-1.1-* || :


TIL what || : does. I think I've used || true or the like for similar behavior elsewhere. Out of curiosity: is one better / more compatible / more idiomatic than the other?

tldr: no practical difference

My cases:

Use true for condition:

e.g.: while true; do ...

Use : for ignoring, doing nothing, ...:

e.g.: ... || :: Ignore error

e.g.: : command line: Ignore this command line (same as # command line but it works with multiline command line. I also use echo command line for this case.)

e.g.: if ...; do :; fi: Do nothing (like pass in Python)

e.g.: : ${VARIABLE:=DEFAULT_VALUE}: Do nothing (setting default value by ${...:=...} is the important part)

conbench-apache-arrow · 2025-10-07T21:05:50Z

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit e5c8ccd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.

### Rationale for this change #45964 changed paths of pre-built Apache Arrow C++ binaries for R. But we forgot to update the nightly upload job. ### What changes are included in this PR? Update paths in the nightly upload job. ### Are these changes tested? No... ### Are there any user-facing changes? Yes. * GitHub Issue: #47704 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Nic Crane <[email protected]>

kou · 2025-10-09T04:19:03Z

Failed...:

https://github.com/apache/arrow/actions/runs/18347253579/job/52257191377#step:7:72

ls: cannot access 'binaries/*/*/': No such file or directory

kou · 2025-10-09T04:20:44Z

Ah, the r-binary-packages job failed:

https://github.com/apache/arrow/actions/runs/18347253579/job/52257191377#step:7:30

[  state] Task / Branch                                               Artifacts
-------------------------------------------------------------------------------
[FAILURE] r-binary-packages                                     uploaded 0 / 15
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***36686030
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***35913601
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***35913431
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***35913418
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***35913414
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***35913406
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***35913403
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***30434300
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***30119121
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***30119120
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***30119118
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***30119107
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***30119100
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330491
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330483
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330479
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330476
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330472
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330469
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330467
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330460
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330450
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9330449
 └ https://github.com/ursacomputing/crossbow/actions/runs/18338842929/job/5***9105899
                      r-libarrow-windows-x86_64-21.0.0.100000191\.zip [MISSING]
            r-libarrow-linux-x86_64-openssl-1.0-21.0.0.100000191\.zip [MISSING]
            r-libarrow-linux-x86_64-openssl-1.1-21.0.0.100000191\.zip [MISSING]
            r-libarrow-linux-x86_64-openssl-3.0-21.0.0.100000191\.zip [MISSING]
            r-libarrow-darwin-arm64-openssl-1.1-21.0.0.100000191\.zip [MISSING]
            r-libarrow-darwin-arm64-openssl-3.0-21.0.0.100000191\.zip [MISSING]
           r-libarrow-darwin-x86_64-openssl-1.1-21.0.0.100000191\.zip [MISSING]
           r-libarrow-darwin-x86_64-openssl-3.0-21.0.0.100000191\.zip [MISSING]
       r-pkg__bin__windows__contrib__4.5__arrow_21.0.0.100000191\.zip [MISSING]
       r-pkg__bin__windows__contrib__4.4__arrow_21.0.0.100000191\.zip [MISSING]
r-pkg__bin__macosx__big-sur-x86_64__contrib__4.5__arrow_21.0.0.100000191\.tgz [MISSING]
r-pkg__bin__macosx__big-sur-x86_64__contrib__4.4__arrow_21.0.0.100000191\.tgz [MISSING]
r-pkg__bin__macosx__big-sur-arm64__contrib__4.5__arrow_21.0.0.100000191\.tgz [MISSING]
r-pkg__bin__macosx__big-sur-arm64__contrib__4.4__arrow_21.0.0.100000191\.tgz [MISSING]
                 r-pkg__src__contrib__arrow_21.0.0.100000191\.tar\.gz [MISSING]
ls: cannot access 'binaries/*/*/': No such file or directory
No files found. Stopping upload.

kou · 2025-10-09T04:22:53Z

#47765

…he#47727) ### Rationale for this change apache#45964 changed paths of pre-built Apache Arrow C++ binaries for R. But we forgot to update the nightly upload job. ### What changes are included in this PR? Update paths in the nightly upload job. ### Are these changes tested? No... ### Are there any user-facing changes? Yes. * GitHub Issue: apache#47704 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Nic Crane <[email protected]>

…47984) ### Rationale for this change PR #47727 refactored the R nightly upload workflow to handle r-pkg and r-lib files separately, but we needed to update the variable name used by `file.copy()`, causing the workflow to fail with "object 'current_path' not found" error. ### What changes are included in this PR? Add `current_path <- c(current_pkg_path, current_lib_path)` to combine the two path vectors before the `file.copy()` call on line 145. ### Are these changes tested? No ### Are there any user-facing changes? No * GitHub Issue: #47983 Authored-by: Nic Crane <[email protected]> Signed-off-by: Nic Crane <[email protected]>

[R] Update paths in nightly libarrow upload job

c03ef3f

kou requested review from assignUser, jonkeane and raulcd as code owners October 7, 2025 02:58

github-actions bot added the awaiting committer review Awaiting committer review label Oct 7, 2025

thisisnic approved these changes Oct 7, 2025

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 7, 2025

jonkeane approved these changes Oct 7, 2025

View reviewed changes

thisisnic merged commit e5c8ccd into apache:main Oct 7, 2025
8 checks passed

thisisnic removed the awaiting merge Awaiting merge label Oct 7, 2025

thisisnic mentioned this pull request Oct 7, 2025

[R] R nightlies not syncing to nightlies.apache.org #47704

Closed

github-actions bot added awaiting committer review Awaiting committer review awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 7, 2025

kou deleted the r-nightlies branch October 8, 2025 01:47

jonkeane mentioned this pull request Oct 14, 2025

[CI][Release][R] r-binary-packages job fails on the release candidate branch for 22.0.0 #47821

Closed

thisisnic mentioned this pull request Oct 28, 2025

GH-47983: [CI][R] R nightly upload workflow failing for a few weeks #47984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH-47704: [R] Update paths in nightly libarrow upload job #47727

GH-47704: [R] Update paths in nightly libarrow upload job #47727

Uh oh!

kou commented Oct 7, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

kou commented Oct 7, 2025

Uh oh!

thisisnic left a comment

Uh oh!

jonkeane left a comment

Uh oh!

jonkeane Oct 7, 2025

Uh oh!

assignUser Oct 7, 2025

Uh oh!

kou Oct 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Oct 7, 2025

Uh oh!

kou commented Oct 9, 2025

Uh oh!

kou commented Oct 9, 2025

Uh oh!

kou commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

GH-47704: [R] Update paths in nightly libarrow upload job #47727

GH-47704: [R] Update paths in nightly libarrow upload job #47727

Uh oh!

Conversation

kou commented Oct 7, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

kou commented Oct 7, 2025

Uh oh!

thisisnic left a comment

Choose a reason for hiding this comment

Uh oh!

jonkeane left a comment

Choose a reason for hiding this comment

Uh oh!

jonkeane Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

assignUser Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

kou Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Oct 7, 2025

Uh oh!

kou commented Oct 9, 2025

Uh oh!

kou commented Oct 9, 2025

Uh oh!

kou commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kou commented Oct 7, 2025 •

edited by github-actions bot

Loading

kou Oct 8, 2025 •

edited

Loading