GH-47679: [C++] Register arrow compute calls in ODBC #47680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`arrow-odbc-spi-impl-test` pass locally. Remove `RUN_ALL_TESTS` that wasn't needed; it is no longer needed after fix of apacheGH-47434.
alinaliBQ
changed the title
|
|
Contributor
Author
kou
reviewed
Oct 2, 2025
github-actions
bot
added
awaiting changes
Put kernel registration in a testing environment
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a13525d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
) ### Rationale for this change Need to call function to register Arrow compute calls which is needed due to apache#25025 ### What changes are included in this PR? - Add calls to `arrow::compute::Initialize` - Remove `RUN_ALL_TESTS` that wasn't needed; it is no longer needed after fix of apacheGH-47434. ### Are these changes tested? - `arrow-odbc-spi-impl-test` pass locally. ### Are there any user-facing changes? No PR is extracted from PR apache#46099 * GitHub Issue: apache#47679 Authored-by: Alina (Xi) Li <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Need to call function to register Arrow compute calls which is needed due to #25025
What changes are included in this PR?
arrow::compute::InitializeRUN_ALL_TESTSthat wasn't needed; it is no longer needed after fix of [C++] Many tests are not being run on Windows #47434.Are these changes tested?
arrow-odbc-spi-impl-testpass locally.Are there any user-facing changes?
No
PR is extracted from PR #46099