-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-42173: [R][C++] Writing partitioned dataset on S3 fails if ListBucket is not allowed for the user #47599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
|
|
f7cb2a3
to
558fc5a
Compare
Hi, @jonkeane @thisisnic thanks for any comment || review |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR @simonelbaz! I've given it a look over, and it looks like there's an existing option for this scenario that might be a better solution, though I haven't tried it out myself - let me know what you think.
|
…d if ListBucket is not allowed for the user
…3 failed if ListBucket is not allowed for the user
2facd98
to
2258358
Compare
…3 failed if ListBucket is not allowed for the user
2258358
to
0a064ca
Compare
Co-authored-by: Antoine Pitrou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me. @thisisnic Are you ok with the new argument name and docstring?
…d if ListBucket is not allowed for the user
Thanks for opening a pull request!
Rationale for this change
This PR gives the user to choose not to create directory in the bucket before writing dataset.
In case the
create_directory
option is set to FALSE, no verification will be made by R arrow.The S3 storage will itself verify if the directory exists and if the users has the rigth to modify it.
This way no
ListBucket
orHeadBucket
are necessary to achieve the write operation.What changes are included in this PR?
create_directory
is now available to the user in thewrite_dataset
function.Before this PR, this option was automatically set to TRUE (by default).
Are these changes tested?
Yes
Are there any user-facing changes?
No, the default value for
create_directory
is still TRUE.This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
N/A
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
N/A