Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jul 11, 2025

Rationale for this change

We must use timeout-minutes not timeout for timeout.

What changes are included in this PR?

Fix key.

Are these changes tested?

No.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #47065 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 11, 2025
@kou
Copy link
Member Author

kou commented Jul 11, 2025

+1

RC2 is failed by this problem. I'll try this fix for RC3.

@kou kou merged commit e7f5b6f into apache:main Jul 11, 2025
5 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Jul 11, 2025
@kou kou deleted the rc-timeout branch July 11, 2025 02:08
kou added a commit that referenced this pull request Jul 11, 2025
### Rationale for this change

We must use `timeout-minutes` not `timeout` for timeout.

### What changes are included in this PR?

Fix key.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* GitHub Issue: #47065

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit e7f5b6f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 17 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant