Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Jun 21, 2019

@kszucs kszucs added the WIP PR is work in progress label Jun 21, 2019
@kszucs
Copy link
Member Author

kszucs commented Jun 24, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 24, 2019

AMD64 Conda Crossbow (#24978) builder has been succeeded.

Revision: 14a15b61fcf1ccb00010c70f9937959319e17fd4

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-60

Task Status
conda-linux-gcc-py27 unsupported CI service azure
conda-win-vs2015-py37 Appveyor Status
conda-win-vs2015-py36 Appveyor Status
conda-linux-gcc-py37 unsupported CI service azure
conda-osx-clang-py37 unsupported CI service azure
conda-osx-clang-py27 unsupported CI service azure
conda-osx-clang-py36 unsupported CI service azure
conda-linux-gcc-py36 unsupported CI service azure

@kszucs
Copy link
Member Author

kszucs commented Jun 24, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 24, 2019

AMD64 Conda Crossbow (#24997) builder has been succeeded.

Revision: 5bfdf1a047e9da6b9638d4ece2c6e46778ab5a6c

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-61

Task Status
conda-win-vs2015-py36 Appveyor Status
conda-osx-clang-py36 unsupported CI service azure
conda-osx-clang-py27 unsupported CI service azure
conda-linux-gcc-py36 unsupported CI service azure
conda-osx-clang-py37 unsupported CI service azure
conda-linux-gcc-py37 unsupported CI service azure
conda-linux-gcc-py27 unsupported CI service azure
conda-win-vs2015-py37 Appveyor Status

@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 25, 2019

AMD64 Conda Crossbow (#25036) builder has been succeeded.

Revision: f9a2f5ca12232e66e931b16ce733695789dc3e91

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-62

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 25, 2019

AMD64 Conda Crossbow (#25299) builder has been succeeded.

Revision: ec85d4c5c096cf47b3e416eef45f203f80f9a41b

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-63

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@kszucs kszucs removed the WIP PR is work in progress label Jun 25, 2019
@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

One of the azure build has lost connection, but I cannot restart it on the UI.

@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 25, 2019

AMD64 Conda Crossbow (#25411) builder has been succeeded.

Revision: ea32b2e5cea273a9713b491bfc09ceab9a9def48

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-65

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 25, 2019

AMD64 Conda Crossbow (#25445) builder has been succeeded.

Revision: 597fc8a839f46b99eae8ea06176a1a4d64162441

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-67

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@kszucs kszucs changed the title [Crossbow] Port conda recipes to azure pipelines ARROW-5725: [Crossbow] Port conda recipes to azure pipelines Jun 25, 2019
@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 25, 2019

AMD64 Conda Crossbow (#25501) builder has been succeeded.

Revision: 2605fbaf06ebf419b72b22839dd182483ebf171d

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-69

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

The builds are passing, but the artifacts are not uploaded correctly.

@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jun 25, 2019

AMD64 Conda Crossbow (#25538) builder has been succeeded.

Revision: be7037aeb464a2e3456e4ddef7122b6c79e3055f

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-70

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I have anything constructive to say about this, sorry. Some questions though...

@@ -1,20 +1,3 @@
# Licensed to the Apache Software Foundation (ASF) under one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really mind, but is there a reason why you removed the license headers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these files are mostly ported from the [py]arrow[-cpp] feedstocks. There is a note in the LICENSE.txt that files under dev/tasks/conda-recipes have another license. Also added to the rat exclude list.


# Include g++'s system headers
if [ "$(uname)" == "Linux" ]; then
SYSTEM_INCLUDES=$(echo | ${CXX} -E -Wp,-v -xc++ - 2>&1 | grep '^ ' | awk '{print "-isystem;" substr($1, 1)}' | tr '\n' ';')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally there would be clean way to write this...
btw, here I get:

$ CXX=g++
$ echo $(echo | ${CXX} -E -Wp,-v -xc++ - 2>&1 | grep '^ ' | awk '{print "-isystem;" substr($1, 1)}' | tr '\n' ';')
-isystem;6:;-isystem;7:;-isystem;8:;-isystem;9:;-isystem;10:;-isystem;11:;-isystem;12:;-isystem;13:;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to any suggestions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I have none, sorry.

@kszucs
Copy link
Member Author

kszucs commented Jun 25, 2019

@ursabot crossbow package conda-win-vs2015-py36 conda-win-vs2015-py37

@ursabot
Copy link

ursabot commented Jun 25, 2019

AMD64 Conda Crossbow (#25665) builder has been succeeded.

Revision: 20f6cec

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-73

Task Status
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@kszucs
Copy link
Member Author

kszucs commented Jun 26, 2019

@pitrou the artifacts are properly uploaded to github releases now

@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

Side note, would it be possible for ursabot to post links to artifacts in its report above? Finding files in the github releases is a bit cumbersome.

@kszucs
Copy link
Member Author

kszucs commented Jun 26, 2019

It is more complicated then the report above.

  1. python crossbow.py submit ... creates the branches and triggers the builds on various CIs
  2. python crossbow.py status ... polls the github api about these statuses, checks and release assets

The ursabot crossbow command is not a service like buildbot, thus it is not notified about changes with hooks, and the ursabot crossbow command is currently only a proxy to python crossbow.py submit ..., executed via buildbot.

On the long term I could port the functionality of crossbow into ursabot, but it requires the development of a series of meta services, a meta-scheduler, a meta-builder, a meta-worker. The scheduler would manipulate the crossbow repository directly (preferably via github api instead of native git bindings), the triggered meta builders would follow the logs of other services via their api and we'd be notified about crossbow's status and check updates by github hooks, then we could properly report back all of the results (including the artifacts).

TLDR it is possible, but requires more time.

@pitrou
Copy link
Member

pitrou commented Jun 26, 2019

I don't mean post the links when they are available, but upfront (so they would give a 404 until the build is finished). It depends whether the URLs are deterministic or not...

@kszucs
Copy link
Member Author

kszucs commented Jun 26, 2019

This is how the badges are working. For the conda packages the assets are not deterministic: https://github.com/apache/arrow/pull/4649/files#diff-0abe5ae3589de012350559065a4194a6R155

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. No objection from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants