-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-5725: [Crossbow] Port conda recipes to azure pipelines #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#24978) builder has been succeeded. Revision: 14a15b61fcf1ccb00010c70f9937959319e17fd4 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-60 |
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#24997) builder has been succeeded. Revision: 5bfdf1a047e9da6b9638d4ece2c6e46778ab5a6c Submitted crossbow builds: ursa-labs/crossbow @ ursabot-61 |
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#25036) builder has been succeeded. Revision: f9a2f5ca12232e66e931b16ce733695789dc3e91 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-62
|
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#25299) builder has been succeeded. Revision: ec85d4c5c096cf47b3e416eef45f203f80f9a41b Submitted crossbow builds: ursa-labs/crossbow @ ursabot-63
|
|
One of the azure build has lost connection, but I cannot restart it on the UI. |
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#25411) builder has been succeeded. Revision: ea32b2e5cea273a9713b491bfc09ceab9a9def48 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-65
|
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#25445) builder has been succeeded. Revision: 597fc8a839f46b99eae8ea06176a1a4d64162441 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-67
|
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#25501) builder has been succeeded. Revision: 2605fbaf06ebf419b72b22839dd182483ebf171d Submitted crossbow builds: ursa-labs/crossbow @ ursabot-69
|
|
The builds are passing, but the artifacts are not uploaded correctly. |
|
@ursabot crossbow package -g conda |
|
AMD64 Conda Crossbow (#25538) builder has been succeeded. Revision: be7037aeb464a2e3456e4ddef7122b6c79e3055f Submitted crossbow builds: ursa-labs/crossbow @ ursabot-70
|
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I have anything constructive to say about this, sorry. Some questions though...
| @@ -1,20 +1,3 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really mind, but is there a reason why you removed the license headers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because these files are mostly ported from the [py]arrow[-cpp] feedstocks. There is a note in the LICENSE.txt that files under dev/tasks/conda-recipes have another license. Also added to the rat exclude list.
|
|
||
| # Include g++'s system headers | ||
| if [ "$(uname)" == "Linux" ]; then | ||
| SYSTEM_INCLUDES=$(echo | ${CXX} -E -Wp,-v -xc++ - 2>&1 | grep '^ ' | awk '{print "-isystem;" substr($1, 1)}' | tr '\n' ';') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally there would be clean way to write this...
btw, here I get:
$ CXX=g++
$ echo $(echo | ${CXX} -E -Wp,-v -xc++ - 2>&1 | grep '^ ' | awk '{print "-isystem;" substr($1, 1)}' | tr '\n' ';')
-isystem;6:;-isystem;7:;-isystem;8:;-isystem;9:;-isystem;10:;-isystem;11:;-isystem;12:;-isystem;13:;There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to any suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I have none, sorry.
|
@ursabot crossbow package conda-win-vs2015-py36 conda-win-vs2015-py37 |
|
AMD64 Conda Crossbow (#25665) builder has been succeeded. Revision: 20f6cec Submitted crossbow builds: ursa-labs/crossbow @ ursabot-73
|
|
@pitrou the artifacts are properly uploaded to github releases now |
|
Side note, would it be possible for ursabot to post links to artifacts in its report above? Finding files in the github releases is a bit cumbersome. |
|
It is more complicated then the report above.
The ursabot crossbow command is not a service like buildbot, thus it is not notified about changes with hooks, and the On the long term I could port the functionality of crossbow into ursabot, but it requires the development of a series of TLDR it is possible, but requires more time. |
|
I don't mean post the links when they are available, but upfront (so they would give a 404 until the build is finished). It depends whether the URLs are deterministic or not... |
|
This is how the badges are working. For the conda packages the assets are not deterministic: https://github.com/apache/arrow/pull/4649/files#diff-0abe5ae3589de012350559065a4194a6R155 |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. No objection from me.
Uh oh!
There was an error while loading. Please reload this page.