-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-25025: [C++] Move non core compute kernels into separate shared library #46261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
c7e702b
GH-25025: [C++] Move non core compute kernels into separate shared li…
raulcd e50a405
Try to fix some CGLib Ruby builds
raulcd 205326d
Try to fix R builds
raulcd ba2ef33
Add mising arrow_compute to PKG_CFLAGS and PKG_LIBS on configure.win …
raulcd 697cc4d
Try fixing static link with pkg-config
raulcd 01c63da
Try fixing pkg-config to add arrow_compute to acero and dataset
raulcd 27cfa05
Try changing link order
raulcd 3a4089f
Add target_compile_definitions arrow_compute_static
raulcd fcfc7be
Fix Arrow compute for PyArrow
raulcd 55e604e
Move from arrow::compute::RegisterComputeKernels to arrow::compute::I…
raulcd 235cb38
Some minor comment and restructure improvements
raulcd c134c44
Move chunked_internal to main compute sources as originally
raulcd 75918a3
Fix c-bridge test to add back RunEndEncode/Decode kernels as part of …
raulcd a66969c
Fix symbol visibility and minor docstring/comment updates
raulcd b79b98f
Move ree_util_internal to compute not on libarrow
raulcd b4a0197
Add documentation for the Initialize() function call and move R initi…
raulcd febf61a
Add Arrow Compute to the bundled libs for the wheels
raulcd 50b00bc
Fix docs format
raulcd b59eec5
Try using static variable for R Compute Initialize call
raulcd 35bcf84
Revert back where do we initialize Compute on R
raulcd 9ca85d9
First attempt on debian type packages
raulcd 404faf9
New attempt to apt and yum linux-packages
raulcd d256b4a
Explicitly exclude arrow-compute.pc from libarrow-dev
raulcd e2e6563
Remove arrow-compute.pc from libarrow-dev.install
raulcd 38a9522
Try removing probably unnecessary libs from arrow_compute_core_target
raulcd c470e0a
Re-add XSIMD and Opentelemetry
raulcd b82b8bd
Prioritize using arrow/compute/kernels/api.h instead of arrow/compute…
raulcd 26b86e9
Tackle some review comments -> remove registry.h and add forward decl…
raulcd e44f6cb
Check initialization status for R and Python. Update compute_init_sta…
raulcd bb7cb81
Update docs, remove unnecessary TODO and other minor review changes
raulcd 57d60cd
Move all utility functions from arrow/compute/kernels/codegen_interna…
raulcd 7fe463a
Export required symbols to libarrow_compute
raulcd eb7e722
Revert moving to compute/codegen_internal.cc and only export the requ…
raulcd b0dfe7b
Update to void Initialize() from Status Initialize() as we always ret…
raulcd 4a7a559
Revert "Update to void Initialize() from Status Initialize() as we al…
raulcd e0247bf
Add function to validate arrow compute initialization for CGLib
raulcd 3525cc5
Add garrow_compute_initialize()
kou fc99628
Reduce scope
kou a91696b
Apply suggestions from code review
raulcd e665992
Remove RegisterComputeKernels from being exposed on the api.h
raulcd aec389f
Fix arrow-c-bridge and dlpack tests to correctly link to test librari…
raulcd aadbc33
Update CInitializeCompute to InitializeCompute and move registration …
raulcd 4fcb991
Use StopIfNotOk helper function instead of manually validating status…
raulcd 1d90aeb
Move arrow/compute/kernels/registry.cc to arrow/compute/initialize.cc…
raulcd 6928271
Try moving R Compute Initialize to static initializer instead of in G…
raulcd 8c50aed
Create function to register compute kernels automatically on Init
raulcd 0fcbdb8
Fix includes and update internal to anonymous namespace
raulcd eacf4a5
Simplify compute test env (#92)
zanmato1984 9001ec2
Some updates to R package compute registration
amoeba 4081927
Remove redundant if directive
amoeba b9e6879
Update cpp/src/arrow/c/bridge_test.cc
raulcd fd48b7a
Add comment to Initialize to specify that it will only be available i…
raulcd 7526369
Remove now unnecessary check ARROW_VERSION_MAJOR >= 21 for R
raulcd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| # This config sets the following variables in your project:: | ||
| # | ||
| # ArrowCompute_FOUND - true if Arrow Compute found on the system | ||
| # | ||
| # This config sets the following targets in your project:: | ||
| # | ||
| # ArrowCompute::arrow_compute_shared - for linked as shared library if shared library is built | ||
| # ArrowCompute::arrow_compute_static - for linked as static library if static library is built | ||
|
|
||
| @PACKAGE_INIT@ | ||
|
|
||
| include(CMakeFindDependencyMacro) | ||
| find_dependency(Arrow CONFIG) | ||
|
|
||
| include("${CMAKE_CURRENT_LIST_DIR}/ArrowComputeTargets.cmake") | ||
|
|
||
| arrow_keep_backward_compatibility(ArrowCompute arrow_compute) | ||
|
|
||
| check_required_components(ArrowCompute) | ||
|
|
||
| arrow_show_details(ArrowCompute ARROW_COMPUTE) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be done implicitly by the Dataset layer? Or is it not possible? cc @bkietz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arrow::dataset::internal::Initialize could certainly call
arrow::compute::Initialize. However that function only registers dataset ExecNode factories, and isn't used here. Implicit initialization is something I'd recommend avoiding until we can provide better guarantees