Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 28, 2025

Rationale for this change

FlatBuffers v24.3.7 was released over one year ago (on Mar 8, 2024), we had better use the latest version in order to support Swift 6+ officially.

What changes are included in this PR?

Use the latest v25.2.10 instead of v24.3.7.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@dongjoon-hyun dongjoon-hyun requested a review from kou as a code owner April 28, 2025 16:49
@github-actions github-actions bot added the awaiting review Awaiting review label Apr 28, 2025
Copy link

⚠️ GitHub issue #46245 has been automatically assigned in GitHub to PR creator.

@dongjoon-hyun dongjoon-hyun marked this pull request as draft April 28, 2025 16:55
@dongjoon-hyun dongjoon-hyun reopened this May 1, 2025
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review May 1, 2025 14:29
@dongjoon-hyun dongjoon-hyun changed the title GH-46245: Upgrade FlatBuffers to v25.2.10 GH-46245: [Swift] Upgrade FlatBuffers to v25.2.10 May 1, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 314871a into apache:main May 1, 2025
9 checks passed
@kou kou removed the awaiting review Awaiting review label May 1, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label May 1, 2025
@dongjoon-hyun
Copy link
Member Author

Thank you, @kou !

@dongjoon-hyun dongjoon-hyun deleted the GH-46245 branch May 1, 2025 22:03
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 314871a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants