Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Feb 11, 2025

Rationale for this change

Older versions of the actions/cache GitHub action are being deprecated as explained in actions/cache#1510.
Because of this, some CI jobs have started to fail: https://github.com/apache/arrow/actions/runs/13265539807/job/37034895918

Are these changes tested?

Yes, by construction.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #45499 has been automatically assigned in GitHub to PR creator.

@NickCrews
Copy link
Contributor

Looks good to me!

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASF states that pinning is a requirement for third party actions not on apache/*, github/* or actions/*:
https://infra.apache.org/github-actions-policy.html
So this one is not strictly required to be pinned.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Feb 11, 2025
@pitrou pitrou merged commit 13940cd into apache:main Feb 11, 2025
35 of 36 checks passed
@pitrou pitrou removed the awaiting merge Awaiting merge label Feb 11, 2025
@pitrou pitrou deleted the gh45499-actions-cache branch February 11, 2025 17:32
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 13940cd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 21 possible false positives for unstable benchmarks that are known to sometimes produce them.

amoeba pushed a commit that referenced this pull request Apr 7, 2025
### Rationale for this change

Older versions of the `actions/cache` GitHub action are being deprecated as explained in actions/cache#1510.
Because of this, some CI jobs have started to fail: https://github.com/apache/arrow/actions/runs/13265539807/job/37034895918

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

No.
* GitHub Issue: #45499

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants