GH-43956: [C++][Compute] Add Decimal32/64 Casts - #45014
Merged
Merged
Conversation
github-actions
Bot
added
Component: C++
awaiting committer review
3 tasks
paleolimbot
reviewed
Dec 12, 2024
paleolimbot
left a comment
paleolimbot
left a comment
Member
There was a problem hiding this comment.
Thank you for this! I took a look through for copy/paste errors and didn't find any; however, I am not that familiar with this part of the code.
I did test #44882 against this locally and all the tests now pass!
github-actions
Bot
added
awaiting changes
lidavidm
approved these changes
Dec 13, 2024
github-actions
Bot
added
awaiting merge
Member
|
@zeroshade Could you use our merge script in apache/arrow next time? |
Member
Author
|
@kou my bad, been working on |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 313d11a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Furthering the support for Decimal32/Decimal64 among Acero and casting functionality. This is also necessary for #44882 to add support for Decimal32/64 to PyArrow
What changes are included in this PR?
Adding kernels for casting to and from Decimal32/Decimal64 between numeric, floating point, string and other decimal types.
Are these changes tested?
Yes, unit tests are added accordingly.