Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Dec 12, 2024

Rationale for this change

pytest-cython has been released with the relevant bugfix.

Are these changes tested?

Yes, by existing CI builds.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #41002 has been automatically assigned in GitHub to PR creator.

@pitrou
Copy link
Member Author

pitrou commented Dec 12, 2024

@github-actions crossbow submit -g python

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 12, 2024
@github-actions
Copy link

Revision: 28ae00c

Submitted crossbow builds: ursacomputing/crossbow @ actions-ba341bb11c

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-cython2 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.10-substrait GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.9 GitHub Actions
test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-39-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@pitrou
Copy link
Member Author

pitrou commented Dec 12, 2024

Well, it looks like the newer pytest-cython triggers an error in the hypothesis CI build:
https://github.com/ursacomputing/crossbow/actions/runs/12296705269/job/34316261656#step:7:5932

+ pytest -r s -m hypothesis -W error --pyargs pyarrow
/opt/conda/envs/arrow/lib/python3.11/site-packages/pytest_cython/__init__.py:2: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  from pkg_resources import get_distribution
/opt/conda/envs/arrow/lib/python3.11/site-packages/pkg_resources/__init__.py:3154: DeprecationWarning: Deprecated call to `pkg_resources.declare_namespace('sphinxcontrib')`.
Implementing implicit namespace packages (as specified in PEP 420) is preferred to `pkg_resources.declare_namespace`. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
  declare_namespace(pkg)
/opt/conda/envs/arrow/lib/python3.11/site-packages/pytest_cython/plugin.py:36: PytestRemovedIn9Warning: The (path: py.path.local) argument is deprecated, please use (file_path: pathlib.Path)
see https://docs.pytest.org/en/latest/deprecations.html#py-path-local-arguments-for-hooks-replaced-with-pathlib-path
  def pytest_collect_file(file_path: pathlib.Path, path, parent: pytest.Collector) -> pytest.Module:

@pitrou
Copy link
Member Author

pitrou commented Dec 12, 2024

cc @AlenkaF

@AlenkaF
Copy link
Member

AlenkaF commented Jan 14, 2025

The pin has been removed in #45240

@pitrou
Copy link
Member Author

pitrou commented Jan 14, 2025

Ok, great!

@pitrou pitrou closed this Jan 14, 2025
@pitrou pitrou deleted the gh41002-pytest-cython branch January 14, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants