Skip to content

Conversation

@samuelpwlim
Copy link

Rationale for this change

Added a method to read the entire file as a table.

What changes are included in this PR?

Added a method to RecordBatchFileReader files and a corresponding unit test to record_batch_file_reader.cc

Are these changes tested?

Unit test added to record_batch_file_reader.cc

Are there any user-facing changes?

@github-actions github-actions bot added the awaiting review Awaiting review label Dec 8, 2024
@samuelpwlim
Copy link
Author

I'm not sure how to link the JIRA issue to this GitHub issue, any help would be appreciated

@kou kou changed the title GH-32671: [C++] Add ReadTable method to RecordBatchFileReader GH-32671: [MATLAB] Add ReadTable method to RecordBatchFileReader Dec 9, 2024
@kou
Copy link
Member

kou commented Dec 9, 2024

We've migrated to GitHub issues from JIRA. See also: #44936

Where did you find JIRA related information?

@samuelpwlim
Copy link
Author

I noticed this output from the DEV PR / Process (pull_request_target) workflow under the "Add Issue Link" task
Unhandled error: ReferenceError: getJiraInfo is not defined

@kou
Copy link
Member

kou commented Dec 9, 2024

Oh, it may be a problem caused by #44936.
Could you open a new issue for the problem?

@samuelpwlim
Copy link
Author

samuelpwlim commented Dec 9, 2024

Yes, I will also fix my code. Thank you! New issue here

@samuelpwlim samuelpwlim changed the title GH-32671: [MATLAB] Add ReadTable method to RecordBatchFileReader GH-44967: [MATLAB] Add ReadTable method to RecordBatchFileReader Dec 9, 2024
@kou
Copy link
Member

kou commented Dec 9, 2024

Ah, no. I wanted to create a new issue for #44965 (comment) not a copy of #32671.

@kou
Copy link
Member

kou commented Dec 9, 2024

You misunderstood #32671.
It's for the C++ implementation https://github.com/apache/arrow/tree/main/cpp not the MATLAB implementation #44967 .

@samuelpwlim
Copy link
Author

samuelpwlim commented Dec 9, 2024

I apologize. I will close the issue I made and reopen a new one concerning the JIRA issue.
I will also close this PR and reopen a new one that addresses the C++ implementation.
Is that okay?

@kou
Copy link
Member

kou commented Dec 9, 2024

Yes.

Just in case:

@samuelpwlim samuelpwlim closed this Dec 9, 2024
@samuelpwlim
Copy link
Author

Thank you very much! Would I tag the new issue with [Docs] or [C++] or something else?

@kou
Copy link
Member

kou commented Dec 9, 2024

Could you use [CI][Dev]?

@samuelpwlim
Copy link
Author

#44968 Please let me know if this looks okay.
I apologize again for the misunderstanding. This is my first time contributing to an open-source

@kou
Copy link
Member

kou commented Dec 10, 2024

It looks okay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants