Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43808: [C++] set kStrptimeSupportsZone to false for old glibc #44621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Nov 2, 2024

Rationale for this change

Enable tests for libarrow in conda-forge: #35587

What changes are included in this PR?

old glibc does not actually support whatever kStrptimeSupportsZone does; I first wanted to StrptimeZoneOffset, but given that it already has a skip, it seems more reasonable to just use that.

TEST(TimestampParser, StrptimeZoneOffset) {
if (!kStrptimeSupportsZone) {
GTEST_SKIP() << "strptime does not support %z on this platform";
}

The exact lower bound for glibc is hard for me to determine; I know that it passes with 2.28 and that it fails with 2.17. Anything in between is an open question. I went with the conservative option here.

Are these changes tested?

Tested in conda-forge/arrow-cpp-feedstock#1058

Are there any user-facing changes?

Copy link

github-actions bot commented Nov 2, 2024

⚠️ GitHub issue #43808 has been automatically assigned in GitHub to PR creator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant