Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Java] Modify document error description #44539

Closed
wants to merge 1 commit into from

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Oct 26, 2024

Rationale for this change

No need to execute cd java

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@lidavidm
Copy link
Member

I think it helps to imply which directory you should be in. Maybe we can replace it with an explicit "From the java/ subdirectory" or similar?

@caicancai
Copy link
Member Author

I think it helps to imply which directory you should be in. Maybe we can replace it with an explicit "From the java/ subdirectory" or similar?

thanks, how about cd java/gandiva

@caicancai
Copy link
Member Author

@lidavidm I am working on Calcite integrating Arrow with Calcite. Thank you for your excellent work on Arrow.

@lidavidm
Copy link
Member

lidavidm commented Nov 5, 2024

Hi @caicancai sorry for the delay. Glad to hear you are working on the Calcite integration!

I think it helps to imply which directory you should be in. Maybe we can replace it with an explicit "From the java/ subdirectory" or similar?

thanks, how about cd java/gandiva

Shouldn't it be just java? Maven should be invoked from the root

@caicancai caicancai closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants