GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders #43736

jonkeane · 2024-08-17T14:58:43Z

Trying to replicate the issue's on CRAN's M1 machine so that we can fix them.

GitHub Issue: [R] AWS SDK fails to build on one of CRAN's M1 builders #43735

jonkeane · 2024-08-17T14:58:59Z

@github-actions crossbow submit test-r-install-local

github-actions · 2024-08-17T14:59:06Z

⚠️ GitHub issue #43735 has been automatically assigned in GitHub to PR creator.

github-actions · 2024-08-17T15:01:17Z

Revision: bf2bcee416f975d7d2d97dd1842f4390a7252bdd

Submitted crossbow builds: ursacomputing/crossbow @ actions-c51734247c

Task	Status
test-r-install-local

jonkeane · 2024-08-17T15:25:50Z

@github-actions crossbow submit test-r-macos-as-cran

github-actions · 2024-08-17T15:28:07Z

Revision: b366ccc1a3fc0098b2ea3e3db50b1bb1bdda320a

Submitted crossbow builds: ursacomputing/crossbow @ actions-76d2411a11

Task	Status
test-r-macos-as-cran

jonkeane · 2024-08-17T15:40:54Z

@github-actions crossbow submit test-r-macos-as-cran

github-actions · 2024-08-17T15:43:07Z

Revision: b75dd5945183896854d40862f834975c6fbba534

Submitted crossbow builds: ursacomputing/crossbow @ actions-80cddc2e7e

Task	Status
test-r-macos-as-cran

jonkeane · 2024-08-17T15:48:39Z

@github-actions crossbow submit test-r-macos-as-cran

github-actions · 2024-08-17T15:50:56Z

Revision: ddc42f152179bde91a3ab34ebcf322a1c1289abb

Submitted crossbow builds: ursacomputing/crossbow @ actions-1451ffbbe2

Task	Status
test-r-macos-as-cran

jonkeane · 2024-08-17T18:57:13Z

@github-actions crossbow submit test-r-macos-as-cran

github-actions · 2024-08-17T18:59:25Z

Revision: 250e554c93b0eb6b58c17c45ac0453de5b05b4f8

Submitted crossbow builds: ursacomputing/crossbow @ actions-6b92fe50a6

Task	Status
test-r-macos-as-cran

jonkeane · 2024-08-17T19:31:16Z

The R version failure is resolved in #43737

kou · 2024-08-17T21:01:00Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

Could you use "appending -Wno-error*" approach instead of "replacing a flag" approach like we did for gRPC?

arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 3920 to 3940 in 49be60f

set(GRPC_C_FLAGS "${EP_C_FLAGS}")

set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}")

if(NOT MSVC)

# Negate warnings that gRPC cannot build under

# See https://github.com/grpc/grpc/issues/29417

string(APPEND

GRPC_C_FLAGS

" -Wno-attributes"

" -Wno-format-security"

" -Wno-unknown-warning-option")

string(APPEND

GRPC_CXX_FLAGS

" -Wno-attributes"

" -Wno-format-security"

" -Wno-unknown-warning-option")

endif()

set(GRPC_CMAKE_ARGS

"${EP_COMMON_CMAKE_ARGS}"

"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"

"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"

Ah, yes! Thanks for this pointer. I tried constructing this before based on the substrait approach which is similar, but I couldn't get the cmake to work, but this did!

jonkeane · 2024-08-17T22:21:31Z

@github-actions crossbow submit -g r

github-actions · 2024-08-17T22:24:14Z

Revision: 5e80a72

Submitted crossbow builds: ursacomputing/crossbow @ actions-ca72a12061

Task	Status
r-binary-packages
test-r-arrow-backwards-compatibility
test-r-clang-sanitizer
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-macos-as-cran
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-debian-gcc-release-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-opensuse155
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-r-sanitizer

kou · 2024-08-18T01:31:44Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

+  set(AWS_EP_COMMON_CMAKE_ARGS "${EP_COMMON_CMAKE_ARGS}" "-DCMAKE_C_FLAGS=${AWS_C_FLAGS}"
+                               "-DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS}")
+
  set(AWSSDK_COMMON_CMAKE_ARGS
-      ${EP_COMMON_CMAKE_ARGS}
+      ${AWS_EP_COMMON_CMAKE_ARGS}


Can we simplify this by not defining AWS_EP_COMMON_CMAKE_ARGS?

set(AWSSDK_COMMON_CMAKE_ARGS ${EP_COMMON_CMAKE_ARGS} -DCMAKE_C_FLAGS=${AWS_C_FLAGS} -DCMAKE_CXX_FLAGS=${AWS_CXX_FLAGS} ...

dev/tasks/tasks.yml

Co-authored-by: Sutou Kouhei <[email protected]>

jonkeane · 2024-08-18T01:56:58Z

@github-actions crossbow submit test-r-macos-as-cran

github-actions · 2024-08-18T01:59:07Z

Revision: 625a847

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c15b5b2e3

Task	Status
test-r-macos-as-cran

jonkeane · 2024-08-18T12:43:16Z

The failures for Java JNI / AMD64 manylinux2014 Java JNI (pull_request) are the same on main and not related to this PR

…3736) Trying to replicate the issue's on CRAN's M1 machine so that we can fix them. * GitHub Issue: #43735 Lead-authored-by: Jonathan Keane <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Jonathan Keane <[email protected]>

conbench-apache-arrow · 2024-08-18T21:21:21Z

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1ae38d0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

github-actions bot added the awaiting committer review Awaiting committer review label Aug 17, 2024

github-actions bot added the Component: C++ label Aug 17, 2024

kou reviewed Aug 17, 2024

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 17, 2024

jonkeane added 10 commits August 17, 2024 17:20

add cran's strict flags

5c1cb90

a separate, more CRAN-like job for macos

15f54c1

Remove environment setting

5a26b3c

epxlicit not_cran

1e22bf3

Allow aws sdk to build on clang

5756fe0

A comment clarifying

37c6c60

lint

f98ef44

Remove errant changes

cbaddef

A few more flags

a96647d

Use flags approach instead

5e80a72

jonkeane force-pushed the crammacm1 branch from b0e7da2 to 5e80a72 Compare August 17, 2024 22:20

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 17, 2024

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 17, 2024

ugh linting

30149f0

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 17, 2024

last lint?

c13ba9b

kou reviewed Aug 18, 2024

View reviewed changes

dev/tasks/tasks.yml Outdated Show resolved Hide resolved

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 18, 2024

Update dev/tasks/tasks.yml

8df5b13

Co-authored-by: Sutou Kouhei <[email protected]>

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 18, 2024

jonkeane added 2 commits August 17, 2024 20:52

Simplify

d8fef6b

another lint

625a847

jonkeane marked this pull request as ready for review August 18, 2024 12:43

jonkeane requested review from assignUser and raulcd as code owners August 18, 2024 12:43

jonkeane merged commit 1ae38d0 into apache:main Aug 18, 2024

jonkeane removed the awaiting change review Awaiting change review label Aug 18, 2024

jonkeane mentioned this pull request Aug 18, 2024

[R] AWS SDK fails to build on one of CRAN's M1 builders #43735

Closed

jonkeane mentioned this pull request Aug 18, 2024

[R] CRAN packaging checklist for version 17.0.0 #43317

Closed

38 tasks

	set(GRPC_C_FLAGS "${EP_C_FLAGS}")
	set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}")
	if(NOT MSVC)
	# Negate warnings that gRPC cannot build under
	# See https://github.com/grpc/grpc/issues/29417
	string(APPEND
	GRPC_C_FLAGS
	" -Wno-attributes"
	" -Wno-format-security"
	" -Wno-unknown-warning-option")
	string(APPEND
	GRPC_CXX_FLAGS
	" -Wno-attributes"
	" -Wno-format-security"
	" -Wno-unknown-warning-option")
	endif()

	set(GRPC_CMAKE_ARGS
	"${EP_COMMON_CMAKE_ARGS}"
	"-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}"
	"-DCMAKE_CXX_FLAGS=${GRPC_CXX_FLAGS}"

GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders #43736

GH-43735: [R] AWS SDK fails to build on one of CRAN's M1 builders #43736

Uh oh!

Conversation

jonkeane commented Aug 17, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonkeane commented Aug 17, 2024

Uh oh!

github-actions bot commented Aug 17, 2024

Uh oh!

github-actions bot commented Aug 17, 2024

Uh oh!

jonkeane commented Aug 17, 2024

Uh oh!

github-actions bot commented Aug 17, 2024

Uh oh!

jonkeane commented Aug 17, 2024

Uh oh!

github-actions bot commented Aug 17, 2024

Uh oh!

jonkeane commented Aug 17, 2024

Uh oh!

github-actions bot commented Aug 17, 2024

Uh oh!

jonkeane commented Aug 17, 2024

Uh oh!

github-actions bot commented Aug 17, 2024

Uh oh!

jonkeane commented Aug 17, 2024

Uh oh!

kou Aug 17, 2024

Choose a reason for hiding this comment

Uh oh!

jonkeane Aug 17, 2024

Choose a reason for hiding this comment

Uh oh!

jonkeane commented Aug 17, 2024

Uh oh!

github-actions bot commented Aug 17, 2024

Uh oh!

kou Aug 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonkeane commented Aug 18, 2024

Uh oh!

github-actions bot commented Aug 18, 2024

Uh oh!

jonkeane commented Aug 18, 2024

Uh oh!

conbench-apache-arrow bot commented Aug 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jonkeane commented Aug 17, 2024 •

edited by github-actions bot

Loading