Skip to content

GH-43703: [C++][Parquet][CI] Parquet: Introducing more bad_data for testing #43708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 2 commits into from
Aug 15, 2024
Merged

GH-43703: [C++][Parquet][CI] Parquet: Introducing more bad_data for testing #43708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
060e0d5
Parquet: Introducing more bad_data for testing
mapleFU Aug 15, 2024
128df48
fix build by capture max file size
mapleFU Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/build-support/fuzzing/generate_corpuses.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,5 @@ rm -rf ${CORPUS_DIR}
${OUT}/parquet-arrow-generate-fuzz-corpus ${CORPUS_DIR}
# Add Parquet testing examples
cp ${ARROW_CPP}/submodules/parquet-testing/data/*.parquet ${CORPUS_DIR}
cp ${ARROW_CPP}/submodules/parquet-testing/bad_data/*.parquet ${CORPUS_DIR}
${ARROW_CPP}/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} ${OUT}/parquet-arrow-fuzz_seed_corpus.zip
12 changes: 9 additions & 3 deletions cpp/src/parquet/arrow/arrow_reader_writer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5298,14 +5298,20 @@ TEST(TestArrowReadWrite, MultithreadedWrite) {

TEST(TestArrowReadWrite, FuzzReader) {
constexpr size_t kMaxFileSize = 1024 * 1024 * 1;
{
auto path = test::get_data_file("PARQUET-1481.parquet", /*is_good=*/false);
auto check_bad_file = [&](const std::string& file_name) {
SCOPED_TRACE(file_name);
auto path = test::get_data_file(file_name, /*is_good=*/false);
PARQUET_ASSIGN_OR_THROW(auto source, ::arrow::io::MemoryMappedFile::Open(
path, ::arrow::io::FileMode::READ));
PARQUET_ASSIGN_OR_THROW(auto buffer, source->Read(kMaxFileSize));
auto s = internal::FuzzReader(buffer->data(), buffer->size());
ASSERT_NOT_OK(s);
}
};
check_bad_file("PARQUET-1481.parquet");
check_bad_file("ARROW-GH-41317.parquet");
check_bad_file("ARROW-GH-41321.parquet");
check_bad_file("ARROW-RS-GH-6229-LEVELS.parquet");
check_bad_file("ARROW-RS-GH-6229-DICTHEADER.parquet");
{
auto path = test::get_data_file("alltypes_plain.parquet", /*is_good=*/true);
PARQUET_ASSIGN_OR_THROW(auto source, ::arrow::io::MemoryMappedFile::Open(
Expand Down
2 changes: 1 addition & 1 deletion cpp/submodules/parquet-testing
Open in desktop
Submodule parquet-testing updated 10 files
+43 −0 .asf.yaml
+ − bad_data/ARROW-GH-41317.parquet
+ − bad_data/ARROW-GH-41321.parquet
+ − bad_data/ARROW-RS-GH-6229-DICTHEADER.parquet
+ − bad_data/ARROW-RS-GH-6229-LEVELS.parquet
+9 −1 bad_data/README.md
+41 −0 data/README.md
+ − data/column_chunk_key_value_metadata.parquet
+ − data/incorrect_map_schema.parquet
+ − data/sort_columns.parquet