GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled #43689

pitrou · 2024-08-14T13:33:54Z

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

GitHub Issue: [C++] Patch Snappy config to avoid disabling RTTI #43688

github-actions · 2024-08-14T13:34:23Z

⚠️ GitHub issue #43688 has been automatically assigned in GitHub to PR creator.

pitrou · 2024-08-14T13:37:33Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

-  endif()
+  # See comments in snappy.diff.
+  find_program(PATCH patch REQUIRED)
+  set(SNAPPY_PATCH_COMMAND ${PATCH} -p1 -i ${CMAKE_CURRENT_LIST_DIR}/snappy.diff)


@kou Do we require patch to be present on all platforms, especially Windows? Or should I make this more specific?

Well, to answer myself: our emscripten builds don't have access to a patch executable...
https://github.com/ursacomputing/crossbow/actions/runs/10388720694/job/28764995095#step:7:826

And even some Linux builds such as test-r-rocker-r-ver-latest don't seem to have patch either. I'll try to make it optional.

Ok, unfortunately the patch is required. We either have to make sure that patch is available on all images, or do things differently :-/

Yes. patch is required as you noticed.
I think that another approach is better. See also: #43688 (comment)

OTOH, patch is useful and could be needed for other bundled builds.

I think that we should fix in upstream instead of using patch as much as possible :-)

I agree with this, but as you know Snappy rarely takes outside contributions...

pitrou · 2024-08-14T13:37:58Z

@github-actions crossbow submit -g cpp

pitrou · 2024-08-14T13:38:05Z

@github-actions crossbow submit -g python

pitrou · 2024-08-14T13:57:17Z

@github-actions crossbow submit -g r

pitrou · 2024-08-14T14:29:03Z

@github-actions crossbow submit emscripten

pitrou · 2024-08-14T14:30:40Z

@github-actions crossbow submit test-r-rocker-r-ver-latest test-r-rstudio-r-base-4.2-focal test-r-versions r-binary-packages

pitrou · 2024-08-14T14:54:21Z

@github-actions crossbow submit emscripten

pitrou · 2024-08-14T14:54:27Z

@github-actions crossbow submit -g r

github-actions · 2024-08-14T14:59:16Z

Revision: 58adcdb

Submitted crossbow builds: ursacomputing/crossbow @ actions-62889c8077

Task	Status
r-binary-packages
test-r-arrow-backwards-compatibility
test-r-clang-sanitizer
test-r-depsource-bundled
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-valgrind
test-r-minimal-build
test-r-offline-maximal
test-r-offline-minimal
test-r-rhub-debian-gcc-devel-lto-latest
test-r-rhub-debian-gcc-release-custom-ccache
test-r-rhub-ubuntu-release-latest
test-r-rocker-r-ver-latest
test-r-rstudio-r-base-4.1-opensuse155
test-r-rstudio-r-base-4.2-focal
test-r-ubuntu-22.04
test-r-versions
test-ubuntu-r-sanitizer

pitrou · 2024-08-14T15:22:57Z

@github-actions crossbow submit emscripten

github-actions · 2024-08-14T15:25:16Z

Revision: ae1e24b

Submitted crossbow builds: ursacomputing/crossbow @ actions-9f77ba6cb3

Task	Status
test-conda-python-emscripten
test-ubuntu-22.04-cpp-emscripten

pitrou · 2024-08-14T15:53:55Z

@github-actions crossbow submit r-binary-packages

github-actions · 2024-08-14T15:56:09Z

Revision: e545bc3

Submitted crossbow builds: ursacomputing/crossbow @ actions-74e3a4cd44

Task	Status
r-binary-packages

pitrou · 2024-08-14T16:45:21Z

@github-actions crossbow submit -g python -g cpp

github-actions · 2024-08-14T16:48:26Z

Revision: 19228c5

Submitted crossbow builds: ursacomputing/crossbow @ actions-df81c467d5

Task	Status
example-python-minimal-build-fedora-conda
example-python-minimal-build-ubuntu-venv
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-conda-python-3.10
test-conda-python-3.10-cython2
test-conda-python-3.10-hdfs-2.9.2
test-conda-python-3.10-hdfs-3.2.1
test-conda-python-3.10-pandas-latest-numpy-1.26
test-conda-python-3.10-pandas-latest-numpy-latest
test-conda-python-3.10-pandas-nightly-numpy-nightly
test-conda-python-3.10-substrait
test-conda-python-3.11
test-conda-python-3.11-dask-latest
test-conda-python-3.11-dask-upstream_devel
test-conda-python-3.11-hypothesis
test-conda-python-3.11-pandas-upstream_devel-numpy-nightly
test-conda-python-3.11-spark-master
test-conda-python-3.12
test-conda-python-3.12-cpython-debug
test-conda-python-3.8
test-conda-python-3.8-pandas-1.0-numpy-1.19
test-conda-python-3.9
test-conda-python-3.9-pandas-latest-numpy-latest
test-conda-python-emscripten
test-cuda-cpp
test-cuda-python
test-debian-12-cpp-amd64
test-debian-12-cpp-i386
test-debian-12-python-3-amd64
test-debian-12-python-3-i386
test-fedora-39-cpp
test-fedora-39-python-3
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-20.04-python-3
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-22.04-python-3
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14

pitrou · 2024-08-16T10:17:56Z

Closing as outdated, see the alternative and merged PR #43706

apacheGH-43688: [C++] Prevent Snappy from disabling RTTI when bundled

fe31f58

github-actions bot added Component: C++ awaiting review Awaiting review labels Aug 14, 2024

pitrou commented Aug 14, 2024

View reviewed changes

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Aug 14, 2024

This comment was marked as outdated.

Sign in to view

Try to make patch optional

80331aa

This comment was marked as outdated.

Sign in to view

Try to make sure patch is installed

58adcdb

This comment was marked as outdated.

Sign in to view

Also install patch in conda-cpp

ae1e24b

Make sure patch is installed on centos-cpp as well

e545bc3

Fix dev lint run

9df84ac

Try to fix weird errors on GHA

19228c5

kou mentioned this pull request Aug 14, 2024

[C++] Patch Snappy config to avoid disabling RTTI #43688

Closed

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Aug 14, 2024

pitrou closed this Aug 16, 2024

pitrou deleted the gh43688-snappy-remove-no-rtti branch August 16, 2024 10:17

GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled #43689

GH-43688: [C++] Prevent Snappy from disabling RTTI when bundled #43689

Uh oh!

Conversation

pitrou commented Aug 14, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pitrou commented Aug 14, 2024

Uh oh!

pitrou commented Aug 14, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

pitrou commented Aug 14, 2024

Uh oh!

This comment was marked as outdated.

pitrou commented Aug 14, 2024

Uh oh!

pitrou commented Aug 14, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

pitrou commented Aug 14, 2024

Uh oh!

pitrou commented Aug 14, 2024

Uh oh!

This comment was marked as outdated.

github-actions bot commented Aug 14, 2024

Uh oh!

pitrou commented Aug 14, 2024

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

pitrou commented Aug 14, 2024

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

pitrou commented Aug 14, 2024

Uh oh!

github-actions bot commented Aug 14, 2024

Uh oh!

pitrou commented Aug 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pitrou commented Aug 14, 2024 •

edited by github-actions bot

Loading