GH-43643: [Java] LargeListViewVector IPC Integration #43681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhatha
commented
Aug 14, 2024
Comment on lines
+440
to
+443
Contributor
Author
There was a problem hiding this comment.
Added a missed case when adding IPC support for ListViewVector
github-actions
bot
added
awaiting committer review
lidavidm
approved these changes
Aug 14, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 712cfe6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
) ### Rationale for this change Newly introduced `LargeListViewVector` requires the IPC integration for C Data integration tests while mainly supporting IPC format to include this type. ### What changes are included in this PR? Includes the `JsonFileWriter` and `JsonFileReader` along with the corresponding test cases. ### Are these changes tested? Yes, using existing tests but adding new configurations. ### Are there any user-facing changes? No * GitHub Issue: apache#43643 Authored-by: Vibhatha Abeykoon <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Newly introduced
LargeListViewVectorrequires the IPC integration for C Data integration tests while mainly supporting IPC format to include this type.What changes are included in this PR?
Includes the
JsonFileWriterandJsonFileReaderalong with the corresponding test cases.Are these changes tested?
Yes, using existing tests but adding new configurations.
Are there any user-facing changes?
No