Skip to content

Conversation

@vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Aug 12, 2024

Rationale for this change

Integrating the transferPair and copyFrom functionality to LargeListViewVector

What changes are included in this PR?

This PR includes the TransferPairImpl, corresponding functions and test cases.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@vibhatha vibhatha marked this pull request as ready for review August 12, 2024 02:28
@vibhatha vibhatha requested a review from lidavidm as a code owner August 12, 2024 02:28
@github-actions github-actions bot added awaiting committer review Awaiting committer review awaiting changes Awaiting changes and removed awaiting review Awaiting review awaiting committer review Awaiting committer review labels Aug 12, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 13, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 13, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 14, 2024
@vibhatha vibhatha requested a review from lidavidm August 14, 2024 00:38
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Aug 14, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Aug 14, 2024
@vibhatha vibhatha requested a review from lidavidm August 14, 2024 01:45
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Aug 14, 2024
@lidavidm lidavidm merged commit ce251a6 into apache:main Aug 14, 2024
@lidavidm lidavidm removed the awaiting merge Awaiting merge label Aug 14, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ce251a6.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…r implementation (apache#43637)

### Rationale for this change

Integrating the `transferPair` and `copyFrom`  functionality to `LargeListViewVector`

- [X] apache#41292

### What changes are included in this PR?

This PR includes the `TransferPairImpl`, corresponding functions and test cases. 

### Are these changes tested?

Yes

### Are there any user-facing changes?

No
* GitHub Issue: apache#41291

Authored-by: Vibhatha Abeykoon <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants