-
Notifications
You must be signed in to change notification settings - Fork 4k
MINOR: [Docs][Python] Add LargeListType to Data Types docs #43597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit preview-docs |
|
|
@github-actions crossbow submit preview-docs |
|
I'm not familiar with python, would "ListType, LargeListType, FixedSizeListType, ListViewType, LargeListViewType" all required here? |
|
Revision: 499a8a1 Submitted crossbow builds: ursacomputing/crossbow @ actions-a5b1f8dee8
|
|
Yes, I guess all the rest should also be added. I first added only one of them to check if the docs link works as expected. |
|
@jorisvandenbossche @kou Do you think this is ok? I don't know the principle for "type-classes" here |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Could you fill the pull request description template before we merge this?
|
Thanks. |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit bee2fc8. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
@kou, after merging this PR into main branch, the modification does not appear in the dev documentation: https://arrow.apache.org/docs/dev/python/api/datatypes.html#type-classes Do you know why? |
|
We need to fix our nightly documentation build: #43743 |
### Rationale for this change The `LargeListType` is missing in the Data Types docs: https://arrow.apache.org/docs/python/api/datatypes.html#type-classes ### What changes are included in this PR? This PR adds the `LargeListType` to the Data Types docs. ### Are these changes tested? The change only affects the docs. I have generated the docs locally and they appear as expected. See comment below with screenshot: apache/arrow#43597 (comment) ### Are there any user-facing changes? The change is indeed an update in the docs. Authored-by: Albert Villanova del Moral <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

Rationale for this change
The
LargeListTypeis missing in the Data Types docs: https://arrow.apache.org/docs/python/api/datatypes.html#type-classesWhat changes are included in this PR?
This PR adds the
LargeListTypeto the Data Types docs.Are these changes tested?
The change only affects the docs. I have generated the docs locally and they appear as expected. See comment below with screenshot: #43597 (comment)
Are there any user-facing changes?
The change is indeed an update in the docs.