GH-43469: [Java] Change the default CompressionCodec.Factory to leverage compression support transparently - #43471
Conversation
|
|
f852454 to
809f0ce
Compare
…ssion support transparently (apache#43469)
809f0ce to
263d3b1
Compare
|
cc @lidavidm needs approval for the CIs |
lidavidm
left a comment
There was a problem hiding this comment.
CC @danepitkin @vibhatha as well; I think we will have to update various documentation/cookbook recipes since now you don't need explicit configuration
After grepping around, there is no documentation/cookbook that currently uses |
|
Added Cookbook issue here apache/arrow-cookbook#354 |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7e50097. There were 6 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
@danepitkin there are performance regressions 🤔 |
|
Good catch. I took a look and the regressions are all in Arrow R. This looks unrelated to this PR so we can ignore. |
|
Thanks for checking it out @danepitkin |
… leverage compression support transparently (apache#43471) ### Rationale for this change Add compression support to Flight RPC and others by just including the `arrow-compression` jar in the module path (or classpath). ### What changes are included in this PR? Change the default compression factory to the new `CompressionCodec.Factory.INSTANCE`, a ServiceLoader-backed singleton that delegates to the best suited available implementation in the module/class path for each codec type. ### Are these changes tested? yes ### Are there any user-facing changes? No. * GitHub Issue: apache#43469 Authored-by: Costi Ciudatu <ccciudatu@gmail.com> Signed-off-by: Dane Pitkin <dpitkin@apache.org>
Rationale for this change
Add compression support to Flight RPC and others by just including the
arrow-compressionjar in the module path (or classpath).What changes are included in this PR?
Change the default compression factory to the new
CompressionCodec.Factory.INSTANCE, a ServiceLoader-backed singleton that delegates to the best suited available implementation in the module/class path for each codec type.Are these changes tested?
yes
Are there any user-facing changes?
No.