-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-43097: [C++] Implement PathFromUri support for Azure file system
#43098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
PathFromUri support for Azure file systemPathFromUri support for Azure file system
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that other filesystem implementations use internal::PathFromUriHelper(). Can we use it in Azure filesystem too?
I tried that at first, but the issue is that for Azure we have to support different URI schemes where the authority is handled differently. So just using |
Tom-Newton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy 👍
| RETURN_NOT_OK(uri.Parse(uri_string)); | ||
| RETURN_NOT_OK(AzureOptions::FromUri(uri, &path)); | ||
|
|
||
| std::vector<std::string> supported_schemes = {"abfs", "abfss"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It would be nice to have a comment explaining why internal::PathFromUriHelper() can't be used in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I added a comment. 👍
|
@kou Can you give it another look? I think it should be good to go. |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sorry for my late review...
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 88e8140. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
See #43097.
What changes are included in this PR?
Implements
AzureFS::PathFromUriusing existing URI parsing and path extraction inside theAzureOptions.Are these changes tested?
Yes, added a unit test.
Are there any user-facing changes?
No, but calling
PathFromUriwill now work instead of throwing due to no implementation provided.PathFromUrisupport #43097