GH-40944: [Java] Implement TypeEqualsVisitor for StringView #41606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <[email protected]>
|
|
Collaborator
|
@tlm365 thanks for working on this PR. I will take a look today. |
Collaborator
|
@lidavidm could you please help to run the workflows? |
lidavidm
approved these changes
May 10, 2024
github-actions
bot
added
awaiting merge
Collaborator
|
@lidavidm should we also include a test for |
Member
|
This is for type equality... |
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 0e9896d. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
CurtHagenlocher
pushed a commit
to CurtHagenlocher/arrow
that referenced
this pull request
May 13, 2024
…ache#41606) ### Rationale for this change Resolves apache#40944 . ### What changes are included in this PR? ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40944 Authored-by: Tai Le Manh <[email protected]> Signed-off-by: David Li <[email protected]>
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…ache#41606) ### Rationale for this change Resolves apache#40944 . ### What changes are included in this PR? ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40944 Authored-by: Tai Le Manh <[email protected]> Signed-off-by: David Li <[email protected]>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…ache#41606) ### Rationale for this change Resolves apache#40944 . ### What changes are included in this PR? ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40944 Authored-by: Tai Le Manh <[email protected]> Signed-off-by: David Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Resolves #40944 .
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
TypeEqualsVisitorfor StringView #40944