GH-39257: [JS] LargeBinary #39258
GH-39257: [JS] LargeBinary #39258
Conversation
github-actions
bot
added
Component: JavaScript
Component: Documentation
awaiting committer review
| protected _flushPending(pending: Map<number, Uint8Array | undefined>, pendingLength: number) { | ||
| const offsets = this._offsets; | ||
| const data = this._values.reserve(pendingLength).buffer; | ||
| let offset = 0; | ||
| for (const [index, value] of pending) { | ||
| if (value === undefined) { | ||
| offsets.set(index, BigInt(0)); | ||
| } else { | ||
| const length = value.length; | ||
| data.set(value, offset); | ||
| offsets.set(index, BigInt(length)); | ||
| offset += length; | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you want to activate the placeholder in builder/largeutf8.ts in this PR?
Seems like you could probably do the same for getByteLength, too.
(LargeUtf8Builder.prototype as any)._flushPending = (LargeBinaryBuilder.prototype as any)._flushPending;
There was a problem hiding this comment.
Yes, just updated the pull request.
bmschmidt
left a comment
bmschmidt
left a comment
There was a problem hiding this comment.
Looks good to me, fwiw, except for the duplicated code between the utf8 and binary builders. The new unification stuff is nice.
|
Oh good catch. I forgot to remove that duplicate code. |
|
CC @kylebarron |
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 4ec6544. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Merge after apache#39249 * Closes: apache#39257
3 participants
Merge after #39249