GH-37805: [CI][MATLAB] Hard-code release to R2023a for matlab-actions/setup-matlab action in MATLAB CI workflows
#37808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingurney
requested review from
assignUser,
kou and
raulcd
as code owners
This was referenced Sep 20, 2023
Member
Author
|
CI failures are related to #37803. |
sgilmore10
approved these changes
Sep 20, 2023
Member
sgilmore10
left a comment
sgilmore10
left a comment
There was a problem hiding this comment.
Thanks for making this change to fix the CI failures. I think this is the right short-term solution until we figure out what R2023b is failing on Windows.
Member
Author
|
+1 |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit e068b7f. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…lab-actions/setup-matlab` action in MATLAB CI workflows (apache#37808) ### Rationale for this change Due to a recent change to default to `R2023b` by default for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing. Example failure logs: https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70 Our preferred solution to address this in the short term is to explicitly specify the [`release` parameter](https://github.com/matlab-actions/setup-matlab#set-up-matlab) to the `setup-matlab` action to be `R2023a`. In the long term, we can work on figuring out why the build is failing on Windows with `R2023b`. For reference - it appears that the `FindMatlab` CMake module only recently added R2023b to its list of recognized versions: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804 ### What changes are included in this PR? 1. Hard-coded MATLAB `release` to `R2023a` for the [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in the MATLAB CI workflows. ### Are these changes tested? Yes. 1. [MATLAB CI workflows are passing on all platforms in `mathworks/arrow`](https://github.com/mathworks/arrow/actions/runs/6251345588). ### Are there any user-facing changes? No. This change only impacts the MATLAB CI workflows which were defaulting to `R2023a` by default in the past. ### Future Directions 1. apache#37809 * Closes: apache#37805 Authored-by: Kevin Gurney <[email protected]> Signed-off-by: Kevin Gurney <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…lab-actions/setup-matlab` action in MATLAB CI workflows (apache#37808) ### Rationale for this change Due to a recent change to default to `R2023b` by default for the `[matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing. Example failure logs: https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70 Our preferred solution to address this in the short term is to explicitly specify the [`release` parameter](https://github.com/matlab-actions/setup-matlab#set-up-matlab) to the `setup-matlab` action to be `R2023a`. In the long term, we can work on figuring out why the build is failing on Windows with `R2023b`. For reference - it appears that the `FindMatlab` CMake module only recently added R2023b to its list of recognized versions: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804 ### What changes are included in this PR? 1. Hard-coded MATLAB `release` to `R2023a` for the [`matlab-actions/setup-matlab`](https://github.com/matlab-actions/setup-matlab) action in the MATLAB CI workflows. ### Are these changes tested? Yes. 1. [MATLAB CI workflows are passing on all platforms in `mathworks/arrow`](https://github.com/mathworks/arrow/actions/runs/6251345588). ### Are there any user-facing changes? No. This change only impacts the MATLAB CI workflows which were defaulting to `R2023a` by default in the past. ### Future Directions 1. apache#37809 * Closes: apache#37805 Authored-by: Kevin Gurney <[email protected]> Signed-off-by: Kevin Gurney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Due to a recent change to default to
R2023bby default for the[matlab-actions/setup-matlab](https://github.com/matlab-actions/setup-matlab) action in GitHub Actions, the MATLAB CI workflows are failing.Example failure logs:
https://github.com/apache/arrow/actions/runs/6250586979/job/16970596069?pr=37773#step:9:70
Our preferred solution to address this in the short term is to explicitly specify the
releaseparameter to thesetup-matlabaction to beR2023a.In the long term, we can work on figuring out why the build is failing on Windows with
R2023b.For reference - it appears that the
FindMatlabCMake module only recently added R2023b to its list of recognized versions:https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8804
What changes are included in this PR?
releasetoR2023afor thematlab-actions/setup-matlabaction in the MATLAB CI workflows.Are these changes tested?
Yes.
mathworks/arrow.Are there any user-facing changes?
No.
This change only impacts the MATLAB CI workflows which were defaulting to
R2023aby default in the past.Future Directions
R2023b#37809releasetoR2023aformatlab-actions/setup-matlabaction in MATLAB CI workflows #37805