GH-37742: [Python] Enable Cython 3 #37743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
Author
|
TODO: Merge after #37097 lands and Cython 3.0.3 is released. |
danepitkin
force-pushed
the
danepitkin/enable-cython3
branch
from
34373da to
834e022
Compare
Member
Author
|
@github-actions crossbow submit -g python |
|
Revision: 834e022539cfb5c57fc00579888b44d2c349bc87 Submitted crossbow builds: ursacomputing/crossbow @ actions-234a830b9b
|
raulcd
reviewed
Sep 26, 2023
github-actions
bot
added
awaiting changes
danepitkin
force-pushed
the
danepitkin/enable-cython3
branch
from
834e022 to
a7c7946
Compare
github-actions
bot
added
awaiting change review
Member
Author
|
@github-actions crossbow submit -g python |
|
Revision: a7c79460892ebfb1700e70f415f9a27002d2c6e1 Submitted crossbow builds: ursacomputing/crossbow @ actions-8f0b65f6be
|
danepitkin
force-pushed
the
danepitkin/enable-cython3
branch
from
a7c7946 to
3d1a44f
Compare
Member
Author
|
Cython 3.0.3 is released! 🎉 |
Member
Author
|
@github-actions crossbow submit -g python |
|
Revision: 3d1a44f Submitted crossbow builds: ursacomputing/crossbow @ actions-354e90dcf7
|
Member
Author
|
CI failure for |
Member
Author
|
CI failure for |
Member
|
Great! Let's get this in then |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 41359dc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change Enable Cython 3. ### What changes are included in this PR? * Unpin Cython version in builds. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes, pyarrow will build with cython 3 by default. * Closes: apache#37742 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Enable Cython 3. ### What changes are included in this PR? * Unpin Cython version in builds. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes, pyarrow will build with cython 3 by default. * Closes: apache#37742 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Enable Cython 3.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes, pyarrow will build with cython 3 by default.