Skip to content

GH-37608: [C++][Gandiva] TO_DATE function supports YYYY-MM and YYYY #37609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Sep 8, 2023
Merged

GH-37608: [C++][Gandiva] TO_DATE function supports YYYY-MM and YYYY #37609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/util/value_parsing.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,7 @@ static inline bool ParseTimestampStrptime(const char* buf, size_t length,
// ignore the time part
arrow_vendored::date::sys_seconds secs =
arrow_vendored::date::sys_days(arrow_vendored::date::year(result.tm_year + 1900) /
(result.tm_mon + 1) / result.tm_mday);
(result.tm_mon + 1) / std::max(result.tm_mday, 1));
if (!ignore_time_in_day) {
secs += (std::chrono::hours(result.tm_hour) + std::chrono::minutes(result.tm_min) +
std::chrono::seconds(result.tm_sec));
Expand Down
29 changes: 29 additions & 0 deletions cpp/src/gandiva/to_date_holder_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,33 @@ TEST_F(TestToDateHolder, TestSimpleDateTimeMakeError) {
EXPECT_EQ(status.IsInvalid(), true) << status.message();
}

TEST_F(TestToDateHolder, TestSimpleDateYearMonth) {
std::shared_ptr<ToDateHolder> to_date_holder;
ASSERT_OK(ToDateHolder::Make("YYYY-MM", 1, &to_date_holder));

auto& to_date = *to_date_holder;
bool out_valid;
std::string s("2012-12");
int64_t millis_since_epoch =
to_date(&execution_context_, s.data(), (int)s.length(), true, &out_valid);
EXPECT_EQ(millis_since_epoch, 1354320000000);

s = std::string("2012-01");
millis_since_epoch =
to_date(&execution_context_, s.data(), (int)s.length(), true, &out_valid);
EXPECT_EQ(millis_since_epoch, 1325376000000);
}

TEST_F(TestToDateHolder, TestSimpleDateYear) {
std::shared_ptr<ToDateHolder> to_date_holder;
ASSERT_OK(ToDateHolder::Make("YYYY", 1, &to_date_holder));

auto& to_date = *to_date_holder;
bool out_valid;
std::string s("1999");
int64_t millis_since_epoch =
to_date(&execution_context_, s.data(), (int)s.length(), true, &out_valid);
EXPECT_EQ(millis_since_epoch, 915148800000);
}

} // namespace gandiva