ARROW-4491: [Python] Use StringConverter and stringstream instead of std::stoi and std::to_string #3758
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@pitrou Please, help to take a look. |
pitrou
approved these changes
Feb 26, 2019
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
LGTM, but the build issue (see AppVeyor) should be resolved.
pitrou
force-pushed
the
string-conversions
branch
from
ab9a4f5 to
6fb7a1b
Compare
Member
|
I tried to push a fix for the build issue. |
Author
|
Thanks! |
Contributor
|
@guoyuhong Thanks this is really great and I think it fixes the issues :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pcmoritz Asked me to continue this PR #3570, but I don't have the right to change the his repro.