ARROW-4660: [C++] Use set_target_properties for defining GFLAGS_IS_A_DLL #3737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target_compile_definitions() for imported library needs CMake 3.11 or later.
Contributor
|
👍 compiling on Linux, haven't tried on WIN32. |
|
Thanks for fixing this! We met the build error in travis. https://travis-ci.com/ray-project/ray/jobs/181504329 |
Member
|
@guoyuhong This is weird, I would have suggested that this could be related to the CMake version but I've seen this feature working with older versions of CMake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_compile_definitions() for imported library needs CMake 3.11 or
later.