-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-29847: [C++] Build with Azure SDK for C++ #36835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
87452b1
Shefali pr rebased (#6)
Tom-Newton 39cf5e3
Build fixes
Tom-Newton ad39f9d
Azure SDK after managed identity fix
Tom-Newton 5f80cf5
Start a minimal test that instantiates the container client
Tom-Newton 141561e
Try setting openssl to link against more explicitly
Tom-Newton 97eb208
Build Azure SDK more like GCP SDK
Tom-Newton 33b0a41
Debugging
Tom-Newton 1b1dfef
Support openssl 1
Tom-Newton 25b0437
Tidy link libraries
Tom-Newton f316192
Hack to avoid uamqp build failure
Tom-Newton db117bc
I think its working
Tom-Newton c6ee215
Revert unnecessary changes
Tom-Newton 1d736a8
Somewhat functional azurite test
Tom-Newton e1fb471
Avoid checking in vcpkg-custom-ports
Tom-Newton 322f48a
Working test that writes then reads back from azurite
Tom-Newton 8fad9c0
Add a test that initialises different credentials
Tom-Newton 4704d05
Fix finding the system xml2
Tom-Newton ef1b638
Use bundled Azure SDK
Tom-Newton 9244da3
manylinux build fixes
Tom-Newton 23c06a4
Remove Azure SDK bundled on alpine, fedora, debian
Tom-Newton 658dc78
Fix merge
Tom-Newton 8e0df48
Install zip and unzip so vcpkg can be bootstrapped
Tom-Newton 259b771
Fix detecting openssl major version
Tom-Newton 14d7530
Fix rebase
Tom-Newton 518cea4
Tidy
Tom-Newton 37dd76a
Small fix and improve naming consistency
Tom-Newton 2fb3572
vcpkg libxml2
Tom-Newton 37e7239
Add libxml2 dep to the correct vcpkg.json
Tom-Newton 508eb4f
Remove unneeded bundled libxml2 build
Tom-Newton 41359f8
Add Azure libraries to correct vcpkg
Tom-Newton e44a868
Small consistency improvement
Tom-Newton 3b199ae
improve consistency
Tom-Newton 4ec48be
Add missing find_package since removing the capability for bundled li…
Tom-Newton 7aeaabc
Remove explicit off option since its off by default
Tom-Newton cb92ddf
Remove vcpkg libxml which is now unnecessary
Tom-Newton 5e2257f
Tidy + enable azure vcpkg on manylinux build
Tom-Newton 814fa06
Initialise blob client in azurefs.cc to ensure build is working corre…
Tom-Newton 25dc0f2
Use bundled Azure SDK in manylinux build
Tom-Newton 31eea24
Fix libxml2 install in manylinux build
Tom-Newton 8fad644
Fix azure ep log options after rebase
Tom-Newton fd44cf8
REvert unnecessary whitespace change
Tom-Newton 304c951
Update comments
Tom-Newton 05d6d6e
Add comment about confusing version names
Tom-Newton 93817c7
Alphabetical ordering and turn off azure in python wheel builds
Tom-Newton 80f4cd7
Update azurite account name
Tom-Newton 530c6b2
Update cpp/src/arrow/filesystem/azurefs_test.cc
Tom-Newton 2dc551d
Move libxml vcpkg dependency to an azure feature
Tom-Newton f1d5c36
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton 47fb13a
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton 18f3115
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton 6d233b8
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton 5d7bd1c
Rename ARROW_AZURESDK_URL -> ARROW_AZURE_SDK_URL
Tom-Newton bd10541
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton d2ce4bb
Update openssl resolution
Tom-Newton 5dbcad7
Re-enable Azure on manylinux build
Tom-Newton 8bae613
Remove unity build option
Tom-Newton fe2dcde
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton 06283cb
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton e73c271
Revert azurite storage account name
Tom-Newton 2140ede
Working link to system openssl
Tom-Newton b90ad90
Declare dependencies on the exact requirements for each component of …
Tom-Newton 0e4b8e7
Rename AZURESDK -> AZURE_SDK and azuresdk -> azure-sdk
Tom-Newton 621af79
Typo
Tom-Newton 3d005d1
Create FindAzure.cmake
Tom-Newton c0517b2
Somewhat working FindAzure.cmake
Tom-Newton d60ea20
Update bundled configurations
Tom-Newton cfc3c6f
Functional FindAzure.cmake
Tom-Newton 971e017
snake case + update comment
Tom-Newton f16c7e1
Kou's suggestions to minimise dependencies
Tom-Newton e012756
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton 2617c20
Update cpp/cmake_modules/ThirdpartyToolchain.cmake
Tom-Newton 13bdcf7
CMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON
Tom-Newton dca8a6f
Update cpp/src/arrow/filesystem/azurefs_test.cc
Tom-Newton 7a9c67a
Disable azure on manylinux build
Tom-Newton a7a7077
Disable azure on Ubuntu 20 build
Tom-Newton 1212c19
Kou's FetchContent patch
Tom-Newton f357561
Revert now unnecessary zip and unzip apt installs
Tom-Newton 6d3ba28
Remove now unnecessary vcpkg overlays
Tom-Newton 2308559
Fix styles
kou a6fac8f
Revert a needless change
kou 88f792b
Improve naming
kou 2e258d8
Use the official name
kou ff657c1
Fix style
kou 704fde7
Disable vcpkg integration
kou 5c9854a
Fix style
kou 92ce1f9
Update cpp/src/arrow/filesystem/azurefs.cc
Tom-Newton 2b576fd
Use `fetchcontent_makeavailable`
Tom-Newton a205b87
Patch for disabling Werror in Azure build
Tom-Newton 19e6a56
Add comment
Tom-Newton f5ebc08
Use newer Azure SDK with support for older curl
Tom-Newton 1ef88c8
Re-enable Azure build on ubuntu 20
Tom-Newton 6398a65
Require azure-core >= 1.10.2 in FindAzure.cmake
Tom-Newton e3fb84c
Fix a lint failure
kou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| if(Azure_FOUND) | ||
| return() | ||
| endif() | ||
|
|
||
| set(find_package_args) | ||
| list(APPEND find_package_args CONFIG) | ||
| if(Azure_FIND_QUIETLY) | ||
| list(APPEND find_package_args QUIET) | ||
| endif() | ||
|
|
||
| if(Azure_FIND_REQUIRED) | ||
| list(APPEND find_package_args REQUIRED) | ||
| endif() | ||
|
|
||
| find_package(azure-core-cpp ${find_package_args}) | ||
| find_package(azure-identity-cpp ${find_package_args}) | ||
| find_package(azure-storage-blobs-cpp ${find_package_args}) | ||
| find_package(azure-storage-common-cpp ${find_package_args}) | ||
| find_package(azure-storage-files-datalake-cpp ${find_package_args}) | ||
|
|
||
| find_package_handle_standard_args( | ||
| Azure | ||
| REQUIRED_VARS azure-core-cpp_FOUND | ||
| azure-identity-cpp_FOUND | ||
| azure-storage-blobs-cpp_FOUND | ||
| azure-storage-common-cpp_FOUND | ||
| azure-storage-files-datalake-cpp_FOUND | ||
| VERSION_VAR azure-core-cpp_VERSION) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.