Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Feb 17, 2019

We can detect LLVM installed by Homebrew automatically in CMake.

We can detect LLVM installed by Homebrew automatically in CMake.
@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #3674 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3674      +/-   ##
==========================================
- Coverage   87.78%   87.77%   -0.01%     
==========================================
  Files         689      689              
  Lines       84023    84023              
  Branches     1081     1081              
==========================================
- Hits        73757    73755       -2     
- Misses      10151    10153       +2     
  Partials      115      115
Impacted Files Coverage Δ
js/src/ipc/metadata/json.ts 92.39% <0%> (-4.35%) ⬇️
cpp/src/plasma/thirdparty/ae/ae.c 72.03% <0%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c340b4...70d4bf6. Read the comment docs.

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kszucs kszucs closed this in a7e93a5 Feb 17, 2019
@kou kou deleted the travis-remove-needless-llvm-dir branch February 17, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants