-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-4552: [JS] Add high-level Table and Column convenience methods #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 24 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6ddfaf8
narrow the FloatVector.from() return signatures
trxcllnt 5dfc100
make the abstract Vector a type alias to trick TS into letting us ove…
trxcllnt 97c349e
add nullable and metadata getters to the Column class
trxcllnt db39031
add public Field#clone impl for convenience
trxcllnt 0407cd7
add Column.new() convenience method for creating Columns with string …
trxcllnt 9d1f2ad
add Table.new() convenience method for creating Tables from Columns o…
trxcllnt bdb23b8
ensure uniform chunk lengths in RecordBatch.from()
trxcllnt 933b531
Narrow the signature of Schema#fields to Field<T[keyof T]>[], cleanup
trxcllnt c9eeb05
fix lint
trxcllnt 3f16c81
fix typo
trxcllnt 8218f40
Ensure Chunked#slice() range end is correct when there's only a singl…
trxcllnt 85d0e00
fix uniform chunk distribution when the new chunks are longer than th…
trxcllnt 9d8f493
cleanup: use the specialized typed array casting functions
trxcllnt b2153aa
ensure the Vector map types always fall back to BaseVector
trxcllnt cf6f97a
add TypeComparator visitor so we can compare Schemas, Fields, and Dat…
trxcllnt 0ac786c
add selectAt() method to Table, Schema, and RecordBatch for selecting…
trxcllnt 99e8888
add Table and Schema assign() impls
trxcllnt e4a5d87
split out the generated data validators for reuse
trxcllnt 07a2c96
add basic Table#assign tests
trxcllnt 41aa902
Add more tests to ensure Tables can serialize through various slice, …
trxcllnt 7a8daad
clean up/speed up: move common argument flattening methods into a uti…
trxcllnt a67bd56
clean up: eliminate more getters in favor of read-only properties
trxcllnt 83de5ed
guard against out-of-bounds selections
trxcllnt 73b8af7
fix Int64Vector typings
trxcllnt dc80143
remove Table.fromVectors in favor of Table.new
trxcllnt 98c8e52
add initial RecordBatch.new and select tests
trxcllnt 5b6d938
cleanup
trxcllnt bfbcc8b
cleanup/rename Table + Schema + RecordBatch from -> new, cleanup argu…
trxcllnt 1758063
add Table.new docstring
trxcllnt 4b8fb54
add a test for table and recordbatch with a single column
trxcllnt 9943d9c
fix lint
trxcllnt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should also be deprecated in favor of a
newversion?