ARROW-4540: [Rust] Basic JSON reader

.travis.yml

@@ -62,6 +62,7 @@ matrix:
     env:
     - ARROW_TRAVIS_VALGRIND=1
     - ARROW_TRAVIS_USE_TOOLCHAIN=1
+    - ARROW_TRAVIS_FLIGHT=1
     - ARROW_TRAVIS_PLASMA=1
     - ARROW_TRAVIS_ORC=1
     - ARROW_TRAVIS_PARQUET=1
@@ -86,10 +87,11 @@ matrix:
     os: linux
     jdk: openjdk8
     env:
+    - ARROW_TRAVIS_COVERAGE=1
     - ARROW_TRAVIS_USE_TOOLCHAIN=1
+    - ARROW_TRAVIS_FLIGHT=1
     - ARROW_TRAVIS_PLASMA=1
     - ARROW_TRAVIS_ORC=1
-    - ARROW_TRAVIS_COVERAGE=1
     - ARROW_TRAVIS_PARQUET=1
     - ARROW_TRAVIS_GANDIVA=1
     - ARROW_TRAVIS_GANDIVA_JAVA=1
@@ -181,6 +183,7 @@ matrix:
     env:
     - ARROW_TRAVIS_USE_TOOLCHAIN=1
     - ARROW_TRAVIS_PLASMA=1
+    - ARROW_TRAVIS_FLIGHT=1
     - ARROW_TRAVIS_ORC=1
     - ARROW_TRAVIS_PARQUET=1
     - ARROW_TRAVIS_GANDIVA=1

c_glib/arrow-glib/array-builder.cpp

@@ -136,9 +136,7 @@ garrow_array_builder_append_nulls(GArrowArrayBuilder *builder,
 
   auto arrow_builder =
     static_cast<BUILDER>(garrow_array_builder_get_raw(builder));
-  uint8_t valid_bytes[n];
-  memset(valid_bytes, 0, sizeof(uint8_t) * n);
-  auto status = arrow_builder->AppendNulls(valid_bytes, n);
+  auto status = arrow_builder->AppendNulls(n);
   return garrow_error_check(error, status, context);
 }
 

c_glib/configure.ac

@@ -99,7 +99,10 @@ fi
 AC_SUBST(GARROW_CFLAGS)
 AC_SUBST(GARROW_CXXFLAGS)
 
-AM_PATH_GLIB_2_0([2.32.4], [], [], [gobject gio])
+AM_PATH_GLIB_2_0([2.32.4],
+                 [],
+                 [AC_MSG_ERROR(GLib isn't available)],
+                 [gobject gio])
 
 GOBJECT_INTROSPECTION_REQUIRE([1.32.1])
 GTK_DOC_CHECK([1.18-2])

c_glib/test/helper/buildable.rb

@@ -101,8 +101,8 @@ def build_string_array(values)
       build_array(Arrow::StringArrayBuilder.new, values)
     end
 
-    def build_list_array(value_data_type, values_list)
-      value_field = Arrow::Field.new("value", value_data_type)
+    def build_list_array(value_data_type, values_list, field_name: "value")
+      value_field = Arrow::Field.new(field_name, value_data_type)
       data_type = Arrow::ListDataType.new(value_field)
       builder = Arrow::ListArrayBuilder.new(data_type)
       values_list.each do |values|

c_glib/test/test-list-array.rb

@@ -19,7 +19,7 @@ class TestListArray < Test::Unit::TestCase
   include Helper::Buildable
 
   def test_new
-    field = Arrow::Field.new("item", Arrow::Int8DataType.new)
+    field = Arrow::Field.new("value", Arrow::Int8DataType.new)
     data_type = Arrow::ListDataType.new(field)
     value_offsets = Arrow::Buffer.new([0, 2, 5, 5].pack("l*"))
     data = Arrow::Buffer.new([1, 2, 3, 4, 5].pack("c*"))

c_glib/test/test-orc-file-reader.rb

@@ -64,7 +64,7 @@ def item_data_type
   end
 
   def build_items_array(items_array)
-    build_list_array(item_data_type, items_array)
+    build_list_array(item_data_type, items_array, field_name: "item")
   end
 
   def items_data_type
@@ -93,7 +93,7 @@ def key_value_data_type
   end
 
   def build_key_value_array(key_value_array)
-    build_list_array(key_value_data_type, key_value_array)
+    build_list_array(key_value_data_type, key_value_array, field_name: "item")
   end
 
   def middle_array

ci/conda_env_cpp.yml

@@ -20,12 +20,14 @@
 boost-cpp=1.68.0
 brotli
 bzip2
+c-ares
 cmake
 double-conversion
 flatbuffers
 gflags
 glog
 gmock
+grpc-cpp
 gtest
 libprotobuf
 lz4-c

ci/docker_install_iwyu.sh

@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -eu
+
+: ${IWYU_REPO:="https://github.com/include-what-you-use/include-what-you-use.git"}
+: ${IWYU_BRANCH:="clang_7.0"}
+: ${IWYU_SRC:="/tmp/iwyu"}
+: ${IWYU_HOME:="/opt/iwyu"}
+
+git clone "${IWYU_REPO}" "${IWYU_SRC}"
+git -C "${IWYU_SRC}" checkout ${IWYU_BRANCH}
+
+mkdir -p "${IWYU_HOME}"
+pushd "${IWYU_HOME}"
+
+# Build IWYU for current Clang
+export CC=clang-7
+export CXX=clang++-7
+
+cmake -DCMAKE_PREFIX_PATH=/usr/lib/llvm-7 "${IWYU_SRC}"
+make -j4
+
+popd

ci/travis_before_script_cpp.sh

@@ -78,61 +78,65 @@ fi
 ARROW_CXXFLAGS=""
 
 # Use Ninja for faster builds when using toolchain
-if [ $ARROW_TRAVIS_USE_TOOLCHAIN == "1" ]; then
+if [ "$ARROW_TRAVIS_USE_TOOLCHAIN" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -GNinja"
   if [ "$DISTRO_CODENAME" != "trusty" ]; then
     # Make sure the toolchain linker (from binutils package) is picked up by clang
     ARROW_CXXFLAGS="$ARROW_CXXFLAGS -B$CPP_TOOLCHAIN/bin"
   fi
 fi
 
-if [ $ARROW_TRAVIS_PLASMA == "1" ]; then
+if [ "$ARROW_TRAVIS_FLIGHT" == "1" ]; then
+  CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_FLIGHT=ON"
+fi
+
+if [ "$ARROW_TRAVIS_PLASMA" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_PLASMA=ON"
 fi
 
-if [ $ARROW_TRAVIS_PLASMA_JAVA_CLIENT == "1" ]; then
+if [ "$ARROW_TRAVIS_PLASMA_JAVA_CLIENT" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_PLASMA_JAVA_CLIENT=ON"
 fi
 
-if [ $ARROW_TRAVIS_ORC == "1" ]; then
+if [ "$ARROW_TRAVIS_ORC" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_ORC=ON"
 fi
 
-if [ $ARROW_TRAVIS_PARQUET == "1" ]; then
+if [ "$ARROW_TRAVIS_PARQUET" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS \
 -DARROW_PARQUET=ON \
 -DPARQUET_BUILD_EXAMPLES=ON \
 -DPARQUET_BUILD_EXECUTABLES=ON"
 fi
 
-if [ $ARROW_TRAVIS_GANDIVA == "1" ]; then
+if [ "$ARROW_TRAVIS_GANDIVA" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_GANDIVA=ON"
-  if [ $ARROW_TRAVIS_GANDIVA_JAVA == "1" ]; then
+  if [ "$ARROW_TRAVIS_GANDIVA_JAVA" == "1" ]; then
       CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_GANDIVA_JAVA=ON"
   fi
 fi
 
-if [ $ARROW_TRAVIS_VALGRIND == "1" ]; then
+if [ "$ARROW_TRAVIS_VALGRIND" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_TEST_MEMCHECK=ON"
 fi
 
-if [ $ARROW_TRAVIS_COVERAGE == "1" ]; then
+if [ "$ARROW_TRAVIS_COVERAGE" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_GENERATE_COVERAGE=ON"
 fi
 
-if [ $ARROW_TRAVIS_VERBOSE == "1" ]; then
+if [ "$ARROW_TRAVIS_VERBOSE" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_VERBOSE_THIRDPARTY_BUILD=ON"
 fi
 
-if [ $ARROW_TRAVIS_VENDORED_BOOST == "1" ]; then
+if [ "$ARROW_TRAVIS_VENDORED_BOOST" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_BOOST_VENDORED=ON"
 fi
 
-if [ $ARROW_TRAVIS_STATIC_BOOST == "1" ]; then
+if [ "$ARROW_TRAVIS_STATIC_BOOST" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_BOOST_USE_SHARED=OFF"
 fi
 
-if [ $ARROW_TRAVIS_OPTIONAL_INSTALL == "1" ]; then
+if [ "$ARROW_TRAVIS_OPTIONAL_INSTALL" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_OPTIONAL_INSTALL=ON"
 fi
 
@@ -147,7 +151,6 @@ else
     if [ "$using_homebrew" = "yes" ]; then
 	# build against homebrew's boost if we're using it
 	export BOOST_ROOT=$(brew --prefix boost)
-	export LLVM_DIR=$(brew --prefix llvm@6)/lib/cmake/llvm
 	export THRIFT_HOME=$(brew --prefix thrift)
     fi
     cmake $CMAKE_COMMON_FLAGS \

ci/travis_install_toolchain.sh

@@ -25,7 +25,7 @@ if [ ! -e $CPP_TOOLCHAIN ]; then
     CONDA_PACKAGES=""
     CONDA_LABEL=""
 
-    if [ $ARROW_TRAVIS_GANDIVA == "1" ] && [ $TRAVIS_OS_NAME == "osx" ]; then
+    if [ "$ARROW_TRAVIS_GANDIVA" == "1" ] && [ $TRAVIS_OS_NAME == "osx" ]; then
         CONDA_PACKAGES="$CONDA_PACKAGES llvmdev=$CONDA_LLVM_VERSION"
     fi
 
@@ -38,7 +38,7 @@ if [ ! -e $CPP_TOOLCHAIN ]; then
         fi
     fi
 
-    if [ $ARROW_TRAVIS_VALGRIND == "1" ]; then
+    if [ "$ARROW_TRAVIS_VALGRIND" == "1" ]; then
         # Use newer Valgrind
         CONDA_PACKAGES="$CONDA_PACKAGES valgrind"
     fi

ci/travis_script_python.sh

@@ -90,11 +90,11 @@ CMAKE_COMMON_FLAGS="-DARROW_EXTRA_ERROR_CONTEXT=ON"
 
 PYTHON_CPP_BUILD_TARGETS="arrow_python-all plasma parquet"
 
-if [ $ARROW_TRAVIS_COVERAGE == "1" ]; then
+if [ "$ARROW_TRAVIS_COVERAGE" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_GENERATE_COVERAGE=ON"
 fi
 
-if [ $ARROW_TRAVIS_PYTHON_GANDIVA == "1" ]; then
+if [ "$ARROW_TRAVIS_PYTHON_GANDIVA" == "1" ]; then
   CMAKE_COMMON_FLAGS="$CMAKE_COMMON_FLAGS -DARROW_GANDIVA=ON"
   PYTHON_CPP_BUILD_TARGETS="$PYTHON_CPP_BUILD_TARGETS gandiva"
 fi
@@ -140,7 +140,7 @@ export PYARROW_BUILD_TYPE=$ARROW_BUILD_TYPE
 export PYARROW_WITH_PARQUET=1
 export PYARROW_WITH_PLASMA=1
 export PYARROW_WITH_ORC=1
-if [ $ARROW_TRAVIS_PYTHON_GANDIVA == "1" ]; then
+if [ "$ARROW_TRAVIS_PYTHON_GANDIVA" == "1" ]; then
   export PYARROW_WITH_GANDIVA=1
 fi
 

cpp/CMakeLists.txt

@@ -844,7 +844,6 @@ endif()
 
 list(APPEND ARROW_LINK_LIBS ${ARROW_SYSTEM_LINK_LIBS})
 list(APPEND ARROW_STATIC_LINK_LIBS ${ARROW_SYSTEM_LINK_LIBS})
-list(APPEND ARROW_SHARED_INSTALL_INTERFACE_LIBS ${ARROW_SYSTEM_LINK_LIBS})
 list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${ARROW_SYSTEM_LINK_LIBS})
 
 #

cpp/build-support/lint_exclusions.txt

@@ -1,3 +1,4 @@
+*codegen*
 *_generated*
 *windows_compatibility.h
 *pyarrow_api.h

cpp/build-support/run_cpplint.py

@@ -112,6 +112,8 @@ def _check_some_files(completed_processes, filenames):
             if problem_files:
                 msg = "{} had cpplint issues"
                 print("\n".join(map(msg.format, problem_files)))
+                if isinstance(stdout, bytes):
+                    stdout = stdout.decode('utf8')
                 print(stdout, file=sys.stderr)
                 error = True
     except Exception:

cpp/cmake_modules/BuildUtils.cmake

@@ -206,16 +206,10 @@ function(ADD_ARROW_LIB LIB_NAME)
       VERSION "${ARROW_FULL_SO_VERSION}"
       SOVERSION "${ARROW_SO_VERSION}")
 
-    if (ARG_SHARED_INSTALL_INTERFACE_LIBS)
-      set(INTERFACE_LIBS ${ARG_SHARED_INSTALL_INTERFACE_LIBS})
-    else()
-      set(INTERFACE_LIBS ${ARG_SHARED_LINK_LIBS})
-    endif()
-
     target_link_libraries(${LIB_NAME}_shared
       LINK_PUBLIC
       "$<BUILD_INTERFACE:${ARG_SHARED_LINK_LIBS}>"
-      "$<INSTALL_INTERFACE:${INTERFACE_LIBS}>"
+      "$<INSTALL_INTERFACE:${ARG_SHARED_INSTALL_INTERFACE_LIBS}>"
       LINK_PRIVATE ${ARG_SHARED_PRIVATE_LINK_LIBS})
 
     if (ARROW_RPATH_ORIGIN)

cpp/cmake_modules/FindArrow.cmake

@@ -79,6 +79,14 @@ find_library(ARROW_PYTHON_LIB_PATH NAMES arrow_python
   NO_DEFAULT_PATH)
 get_filename_component(ARROW_PYTHON_LIBS ${ARROW_PYTHON_LIB_PATH} DIRECTORY)
 
+if (PYARROW_BUILD_FLIGHT)
+  find_library(ARROW_FLIGHT_LIB_PATH NAMES arrow_flight
+    PATHS
+    ${ARROW_SEARCH_LIB_PATH}
+    NO_DEFAULT_PATH)
+  get_filename_component(ARROW_FLIGHT_LIBS ${ARROW_FLIGHT_LIB_PATH} DIRECTORY)
+endif()
+
 if (MSVC)
   SET(CMAKE_FIND_LIBRARY_SUFFIXES ".lib" ".dll")
 
@@ -101,19 +109,25 @@ if (ARROW_INCLUDE_DIR AND ARROW_LIBS)
   set(ARROW_FOUND TRUE)
   set(ARROW_LIB_NAME arrow)
   set(ARROW_PYTHON_LIB_NAME arrow_python)
+  set(ARROW_FLIGHT_LIB_NAME arrow_flight)
   if (MSVC)
     set(ARROW_STATIC_LIB ${ARROW_LIBS}/${ARROW_LIB_NAME}${ARROW_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_SUFFIX})
     set(ARROW_PYTHON_STATIC_LIB ${ARROW_PYTHON_LIBS}/${ARROW_PYTHON_LIB_NAME}${ARROW_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_SUFFIX})
+    set(ARROW_FLIGHT_STATIC_LIB ${ARROW_FLIGHT_LIBS}/${ARROW_FLIGHT_LIB_NAME}${ARROW_MSVC_STATIC_LIB_SUFFIX}${CMAKE_STATIC_LIBRARY_SUFFIX})
     set(ARROW_SHARED_LIB ${ARROW_SHARED_LIBS}/${ARROW_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX})
     set(ARROW_PYTHON_SHARED_LIB ${ARROW_PYTHON_SHARED_LIBS}/${ARROW_PYTHON_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX})
+    set(ARROW_FLIGHT_SHARED_LIB ${ARROW_FLIGHT_SHARED_LIBS}/${ARROW_FLIGHT_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX})
     set(ARROW_SHARED_IMP_LIB ${ARROW_LIBS}/${ARROW_LIB_NAME}.lib)
     set(ARROW_PYTHON_SHARED_IMP_LIB ${ARROW_PYTHON_LIBS}/${ARROW_PYTHON_LIB_NAME}.lib)
+    set(ARROW_FLIGHT_SHARED_IMP_LIB ${ARROW_FLIGHT_LIBS}/${ARROW_FLIGHT_LIB_NAME}.lib)
   else()
     set(ARROW_STATIC_LIB ${ARROW_LIBS}/lib${ARROW_LIB_NAME}.a)
     set(ARROW_PYTHON_STATIC_LIB ${ARROW_LIBS}/lib${ARROW_PYTHON_LIB_NAME}.a)
+    set(ARROW_FLIGHT_STATIC_LIB ${ARROW_LIBS}/lib${ARROW_FLIGHT_LIB_NAME}.a)
 
     set(ARROW_SHARED_LIB ${ARROW_LIBS}/lib${ARROW_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX})
     set(ARROW_PYTHON_SHARED_LIB ${ARROW_LIBS}/lib${ARROW_PYTHON_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX})
+    set(ARROW_FLIGHT_SHARED_LIB ${ARROW_LIBS}/lib${ARROW_FLIGHT_LIB_NAME}${CMAKE_SHARED_LIBRARY_SUFFIX})
   endif()
 endif()
 

cpp/cmake_modules/Findc-ares.cmake

@@ -42,8 +42,9 @@ if (MSVC)
 else ()
   set(CARES_LIB_NAME
     ${CMAKE_SHARED_LIBRARY_PREFIX}cares${CMAKE_SHARED_LIBRARY_SUFFIX})
-  set(CARES_STATIC_LIB_NAME
-    ${CMAKE_STATIC_LIBRARY_PREFIX}cares${CMAKE_STATIC_LIBRARY_SUFFIX})
+  set(CARES_STATIC_LIB_NAMES
+    ${CMAKE_STATIC_LIBRARY_PREFIX}cares${CMAKE_STATIC_LIBRARY_SUFFIX}
+    ${CMAKE_STATIC_LIBRARY_PREFIX}cares_static${CMAKE_STATIC_LIBRARY_SUFFIX})
 endif ()
 
 # Try the parameterized roots, if they exist
@@ -56,7 +57,7 @@ if (_cares_roots)
     PATHS ${_cares_roots} NO_DEFAULT_PATH
     PATH_SUFFIXES "lib")
   find_library(CARES_STATIC_LIB
-    NAMES ${CARES_STATIC_LIB_NAME}
+    NAMES ${CARES_STATIC_LIB_NAMES}
     PATHS ${_cares_roots} NO_DEFAULT_PATH
     PATH_SUFFIXES "lib")
 else ()