ARROW-4535: [C++] Fix MakeBuilder to preserve ListType's field name #3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkn
changed the title
kou
reviewed
Feb 12, 2019
Member
There was a problem hiding this comment.
I think that we don't need this assertion.
This is tests on C++ layer.
mrkn
force-pushed
the
fix_make_builder_to_preserve_field_name_of_list_type
branch
from
d5b0e68 to
34f9fd7
Compare
Member
|
The test failure on Travis CI is related to a We need to fix this bug. The fix of this breaks backward compatibility but this is acceptable. Because normal users don't use |
Member
Author
|
@kou I'll make another pull-request to modify |
Member
|
Thanks! |
MakeBuilder doesn't preserve the field name in the given ListType. I think this is a bug.
mrkn
force-pushed
the
fix_make_builder_to_preserve_field_name_of_list_type
branch
from
34f9fd7 to
54c18c7
Compare
mrkn
force-pushed
the
fix_make_builder_to_preserve_field_name_of_list_type
branch
from
54c18c7 to
e4d8597
Compare
mrkn
deleted the
fix_make_builder_to_preserve_field_name_of_list_type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakeBuilder doesn't preserve the field name in the given ListType.
I think this is a bug.