Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-3814: [R] RecordBatch$from_arrays() #3565

Closed
wants to merge 21 commits into from
Closed

ARROW-3814: [R] RecordBatch$from_arrays() #3565

wants to merge 21 commits into from

Commits on Jun 3, 2019

  1. schema() supports tidy dots splicing, using rlang::list2

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    9a0f996 View commit details
    Browse the repository at this point in the history

  2. + list_to_shared_ptr_vector

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    cd03e19 View commit details
    Browse the repository at this point in the history

  3. Change record_batch() api so that it takes ... and schema. 

    Needs discussion I guess
    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    d49906a View commit details
    Browse the repository at this point in the history

  4. update docs

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c71d872 View commit details
    Browse the repository at this point in the history

  5. move the logic of RecordBatch__from_arrays internally. 

    This will make it easier to do in parallel later.
    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    20c5ce6 View commit details
    Browse the repository at this point in the history

  6. retire RecordBatch__from_dataframe() function, no longer needed and r… 

    …eplaced by RecordBatch__from_arrays()
    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c5ad626 View commit details
    Browse the repository at this point in the history

  7. table() factory also handles ... and !!! a schema, similar to record_… 

    …batch()
    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c00774a View commit details
    Browse the repository at this point in the history

  8. table(...) cab now either handle ... being: 

    - list of record batches
- list of
  - arrays
  - chunked arrays
  - columns
  - r vectors
    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    41b496f View commit details
    Browse the repository at this point in the history

  9. test for table(...<batches>)

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    7e8a4b7 View commit details
    Browse the repository at this point in the history

  10. tests for table(...<vectors, arrays, chunked arrays>)

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    68744f5 View commit details
    Browse the repository at this point in the history

  11. use the schema= argument in table()

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    d8e627f View commit details
    Browse the repository at this point in the history

  12. record_batch(..., schema = )

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    d958108 View commit details
    Browse the repository at this point in the history

  13. directly return from builder_->Finish(), as suggested here: https://g… 

    …ithub.com/apache/arrow/pull/3635/files/08b295370271f122b410b991282b4919510b5cea#r261012517
    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    fc885fd View commit details
    Browse the repository at this point in the history

  14. tests about record_batch(schema=) argument

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c04f904 View commit details
    Browse the repository at this point in the history

  15. STOP_IF migth be useful too

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    4574942 View commit details
    Browse the repository at this point in the history

  16. record_batch(schema=) compares names

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    efd84c5 View commit details
    Browse the repository at this point in the history

  17. add comments about !!!

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    eed535f View commit details
    Browse the repository at this point in the history

  18. typo

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    2362ea0 View commit details
    Browse the repository at this point in the history

  19. Also run cpplint and clang-format on .cpp files

    @wesm @romainfrancois
    wesm authored and romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    f27dcb9 View commit details
    Browse the repository at this point in the history

  20. rebase

    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    6ea0778 View commit details
    Browse the repository at this point in the history

  21. only pass $1 to run_clang_format so that we can do: 

    ./r/lint.sh --fix
    @romainfrancois
    romainfrancois committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    ab0cd16 View commit details
    Browse the repository at this point in the history