-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-35040: [Python] Pyarrow scalar cast should use compute kernel #35395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Build error is unrelated. The error exists on main (and in other PRs). |
AlenkaF
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Just a small nit though: I would also add a test for casting float to int, using default safe option and an unsafe casting option. Not sure about the memory pool though.
Yes, the failing tests are not related, I have created an issue for it: #35490
Great idea! I will add this test. |
23f54a8 to
689fe59
Compare
|
The failure in the MacOS build could now be corrected with a rebase. |
689fe59 to
8de3749
Compare
|
Thank you for the update Dane! |
|
Benchmark runs are scheduled for baseline = e7a885d and contender = 053b5ee. 053b5ee is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
apache#35395) ### Rationale for this change Scalar cast should use the computer kernel just like Arrays, instead of its own custom implementation. ### Are these changes tested? Added test cases for apacheGH-35370, apacheGH-34901, and apacheGH-35040 ### Are there any user-facing changes? The Scalar.cast() API is enhanced and backwards compatible. * Closes: apache#35040 Authored-by: Dane Pitkin <[email protected]> Signed-off-by: Alenka Frim <[email protected]>
…use it requires tz database (#35735) ### Rationale for this change Fix up of #35395, skipping one of the tests added in that PR on Windows, because the test requires access to a tz database. Authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Joris Van den Bossche <[email protected]>
|
xref #36677 I don't think the new |
Rationale for this change
Scalar cast should use the computer kernel just like Arrays, instead of its own custom implementation.
Are these changes tested?
Added test cases for GH-35370, GH-34901, and GH-35040
Are there any user-facing changes?
The Scalar.cast() API is enhanced and backwards compatible.