ARROW-4249: [Plasma] Clean up client namespace #3392
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3392 +/- ##
==========================================
+ Coverage 88.46% 89.45% +0.99%
==========================================
Files 631 502 -129
Lines 79288 70318 -8970
Branches 1069 0 -1069
==========================================
- Hits 70140 62905 -7235
+ Misses 9037 7413 -1624
+ Partials 111 0 -111
Continue to review full report at Codecov.
|
* update arrow to include apache/arrow#3392 * add appropriate includes * update
| #include "arrow/adapters/tensorflow/convert.h" | ||
| #include "arrow/api.h" | ||
| #include "arrow/io/api.h" | ||
| #include "arrow/util/logging.h" |
There was a problem hiding this comment.
@pcmoritz Would you know why plasma_op.cc includes Tensorflow's logging.h above? It produces a collision in the DCHECK macros.
There was a problem hiding this comment.
where is the DCHECK collision occurring? Are we clobbering their macro or vice versa? We should use ARROW_CHECK (or add ARROW_DCHECK_* aliases) so we can use these in an environment where there is ambiguity. We already disallow DCHECK in public headers
There was a problem hiding this comment.
See line 22 above:
#include "tensorflow/core/platform/logging.h"
4 participants
No description provided.