-
Notifications
You must be signed in to change notification settings - Fork 4.2k
GH-33804: [Python] Add support for manylinux_2_28 wheel #33805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f8fc629
Add manylinux_2_28 wheel
sjperkins bb9268d
Address review comments
sjperkins 424fa08
Fix manylinux variable discrepancies
sjperkins bf6f3b1
Fix incorrect arch causing duplicate yaml keys
sjperkins 26cc4c0
Avoid duplicate keys in task definition
sjperkins b490f15
fix arch and remove ci from python wheel key
sjperkins ee4d79d
underscores to dashes in manylinux 2_28 ccache name
sjperkins d196e09
Update docker-compose.yml
sjperkins 79661a1
Update dev/tasks/tasks.yml
sjperkins 3363331
Create unified manylinux Dockerfile
sjperkins 1171e32
Remove unused install_glibc.sh
sjperkins 59a0fb2
Add comments explaining placement of Python 3.8 on the PATH
sjperkins 46579ae
Improve comment
sjperkins 3924533
Distinguish artifact naming schema produced by auditwheel for differe…
sjperkins a26c20d
Correct jinja2 equality operator
sjperkins cc083e0
Fix jinja2 templating
sjperkins 7bf98e2
openssl wants linux-headers on arm64 platform
sjperkins 3c90df8
spelling
sjperkins d0d6894
Install basic dependencies with dnf, rather than yum
sjperkins 3d640ca
Introduce TEST_WHEEL_PLATFORM_TAGS environment variable
sjperkins 21a7ff1
Fix task.yml errors and lint
sjperkins 0cc575c
Fix typo in artifact string
sjperkins f10be24
Merge branch 'master' into manylinux-2-28
sjperkins 999a927
Merge branch 'master' into manylinux-2-28
sjperkins dbb4473
Merge branch 'main' into manylinux-2-28
sjperkins 9c1a3dc
Merge branch 'main' into manylinux-2-28
sjperkins 95d6827
Add --cross-compile-prefix option to openssl CMakeList.txt
sjperkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| ARG base | ||
| FROM ${base} | ||
|
|
||
| ARG arch | ||
| ARG arch_short | ||
| ARG manylinux | ||
|
|
||
| ENV MANYLINUX_VERSION=${manylinux} | ||
|
|
||
| # Install basic dependencies | ||
| RUN yum install -y git flex curl autoconf zip perl-IPC-Cmd wget | ||
|
|
||
| ENV CPYTHON_VERSION=cp38 | ||
| ENV PATH=/opt/python/${CPYTHON_VERSION}-${CPYTHON_VERSION}/bin:${PATH} | ||
|
|
||
| # Install CMake | ||
| # AWS SDK doesn't work with CMake=3.22 due to https://gitlab.kitware.com/cmake/cmake/-/issues/22524 | ||
| ARG cmake=3.21.4 | ||
| COPY ci/scripts/install_cmake.sh arrow/ci/scripts/ | ||
| RUN /arrow/ci/scripts/install_cmake.sh ${arch} linux ${cmake} /usr/local | ||
|
|
||
| # Install Ninja | ||
| ARG ninja=1.10.2 | ||
| COPY ci/scripts/install_ninja.sh arrow/ci/scripts/ | ||
| RUN /arrow/ci/scripts/install_ninja.sh ${ninja} /usr/local | ||
|
|
||
| # Install ccache | ||
| ARG ccache=4.1 | ||
| COPY ci/scripts/install_ccache.sh arrow/ci/scripts/ | ||
| RUN /arrow/ci/scripts/install_ccache.sh ${ccache} /usr/local | ||
|
|
||
| # Install vcpkg | ||
| ARG vcpkg | ||
| # PEP 600 states that a wheel tagged manylinux_x_y | ||
| # shall work on any distro based on glibc>=x.y | ||
| ARG glibc=2.28 | ||
|
sjperkins marked this conversation as resolved.
Outdated
|
||
| COPY ci/vcpkg/*.patch \ | ||
| ci/vcpkg/*linux*.cmake \ | ||
| arrow/ci/vcpkg/ | ||
| COPY ci/scripts/install_vcpkg.sh \ | ||
| ci/scripts/install_glibc.sh \ | ||
| arrow/ci/scripts/ | ||
| ENV VCPKG_ROOT=/opt/vcpkg | ||
| RUN arrow/ci/scripts/install_vcpkg.sh ${VCPKG_ROOT} ${vcpkg} | ||
| ENV PATH="${PATH}:${VCPKG_ROOT}" | ||
|
|
||
| ARG build_type=release | ||
| ENV CMAKE_BUILD_TYPE=${build_type} \ | ||
| VCPKG_FORCE_SYSTEM_BINARIES=1 \ | ||
| VCPKG_OVERLAY_TRIPLETS=/arrow/ci/vcpkg \ | ||
| VCPKG_DEFAULT_TRIPLET=${arch_short}-linux-static-${build_type} \ | ||
| VCPKG_FEATURE_FLAGS="manifests" | ||
| COPY ci/vcpkg/vcpkg.json arrow/ci/vcpkg/ | ||
| # cannot use the S3 feature here because while aws-sdk-cpp=1.9.160 contains | ||
| # ssl related fixies as well as we can patch the vcpkg portfile to support | ||
| # arm machines it hits ARROW-15141 where we would need to fall back to 1.8.186 | ||
| # but we cannot patch those portfiles since vcpkg-tool handles the checkout of | ||
| # previous versions => use bundled S3 build | ||
| RUN vcpkg install \ | ||
| --clean-after-build \ | ||
| --x-install-root=${VCPKG_ROOT}/installed \ | ||
| --x-manifest-root=/arrow/ci/vcpkg \ | ||
| --x-feature=flight \ | ||
| --x-feature=gcs \ | ||
| --x-feature=json \ | ||
| --x-feature=parquet | ||
|
|
||
| ARG python=3.8 | ||
| ENV PYTHON_VERSION=${python} | ||
| RUN PYTHON_ROOT=$(find /opt/python -name cp${PYTHON_VERSION/./}-*) && \ | ||
| echo "export PATH=$PYTHON_ROOT/bin:\$PATH" >> /etc/profile.d/python.sh | ||
|
|
||
| SHELL ["/bin/bash", "-i", "-c"] | ||
| ENTRYPOINT ["/bin/bash", "-i", "-c"] | ||
|
|
||
| COPY python/requirements-wheel-build.txt /arrow/python/ | ||
| RUN pip install -r /arrow/python/requirements-wheel-build.txt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.