Skip to content

GH-33666: [R] Remove extraneous argument to semi_join #33693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paleolimbot merged 4 commits into from
Jan 17, 2023
Merged

GH-33666: [R] Remove extraneous argument to semi_join #33693

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4aa3754
Fix failing semi-join tests
thisisnic Jan 16, 2023
1ba06e2
Remove other extraneous argument from semi_join
thisisnic Jan 16, 2023
d8822cb
Run styler
thisisnic Jan 16, 2023
fb0e3c1
Revert change
thisisnic Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions r/tests/testthat/test-dplyr-join.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ test_that("left_join with join_by", {
left_join(
to_join %>%
rename(the_grouping = some_grouping),
join_by(some_grouping == the_grouping)
join_by(some_grouping == the_grouping)
Copy link
Member

@paleolimbot paleolimbot Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional?

Copy link
Member Author

@thisisnic thisisnic Jan 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the consequence of running the styler.

) %>%
collect(),
left
Expand Down Expand Up @@ -240,14 +240,7 @@ test_that("full_join", {
test_that("semi_join", {
compare_dplyr_binding(
.input %>%
semi_join(to_join, by = "some_grouping", keep = TRUE) %>%
collect(),
left
)

compare_dplyr_binding(
.input %>%
semi_join(to_join, by = "some_grouping", keep = FALSE) %>%
semi_join(to_join, by = "some_grouping") %>%
collect(),
left
)
Expand Down