ARROW-2565: [Plasma] new subscriber cannot receive notifications about existing objects#2022
Closed
zhijunfu wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-2565: [Plasma] new subscriber cannot receive notifications about existing objects#2022zhijunfu wants to merge 1 commit intoapache:masterfrom
zhijunfu wants to merge 1 commit intoapache:masterfrom
Conversation
…out existing objects, and add unit test
pcmoritz
approved these changes
May 10, 2018
Contributor
pcmoritz
left a comment
pcmoritz
left a comment
There was a problem hiding this comment.
+1 thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client subscribes to plasma store, we need to add its file descriptor to pending_notifications_ map, so that push_notifications() can find the new client and push notifications about existing objects to it.
Also added an unit test case to cover this.
@pcmoritz may you kindly help to take a look please? thanks:)