Skip to content

MINOR: [Python] Fix pre-commit and archery flake8 to honor pyarrow config #15067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raulcd merged 3 commits into from
Jan 16, 2023
Merged

MINOR: [Python] Fix pre-commit and archery flake8 to honor pyarrow config #15067

raulcd merged 3 commits into from
Jan 16, 2023

Conversation

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Dec 22, 2022

#14769 changed the flake8 config for pyarrow to raise max line length to 88, but our linting checks didn't actually follow that.

assignUser
assignUser requested changes Dec 28, 2022
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small fix is needed for the lint job.

.pre-commit-config.yaml
- file
- python
exclude: vendored
args: [--config, python/setup.cfg]
Copy link
Member

@assignUser assignUser Dec 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the absolute path here as precommit should run within the arrow dir by default?

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I assume so

@jorisvandenbossche jorisvandenbossche mentioned this pull request Jan 16, 2023
Merged
@raulcd raulcd merged commit 2f8e2b2 into apache:master Jan 16, 2023
@jorisvandenbossche jorisvandenbossche deleted the minor-fix-flake8 branch January 16, 2023 15:00
@ursabot
Copy link

ursabot commented Jan 17, 2023

Benchmark runs are scheduled for baseline = 16c85b2 and contender = 2f8e2b2. 2f8e2b2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.12% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.06% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2f8e2b20 ec2-t3-xlarge-us-east-2
[Finished] 2f8e2b20 test-mac-arm
[Finished] 2f8e2b20 ursa-i9-9960x
[Finished] 2f8e2b20 ursa-thinkcentre-m75q
[Finished] 16c85b2a ec2-t3-xlarge-us-east-2
[Failed] 16c85b2a test-mac-arm
[Finished] 16c85b2a ursa-i9-9960x
[Finished] 16c85b2a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser assignUser requested changes

@raulcd raulcd raulcd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jorisvandenbossche @ursabot @raulcd @assignUser