Skip to content

Conversation

@zeroshade
Copy link
Member

As mentioned by @kou here: #14952 (comment) it looks like we crossed a threshold on the Go benchmarks and have added enough benchmarks for the Compute module that they are collectively taking more than 10m to run (which is the default timeout). So this updates the timeout used for running the benchmarks to 20 minutes.

CC @austin3dickey

@zeroshade zeroshade requested a review from kou December 15, 2022 18:03
@zeroshade zeroshade merged commit 2708c08 into apache:master Dec 15, 2022
@zeroshade zeroshade deleted the fix-go-benchmark-timeout branch December 15, 2022 18:51
@kou
Copy link
Member

kou commented Dec 15, 2022

@zeroshade It's still failing... https://github.com/apache/arrow/actions/runs/3707051286/jobs/6282999469#step:7:432

*** Test killed with quit: ran too long (11m0s).

Could you test this on your fork before you merge?

@ursabot
Copy link

ursabot commented Dec 17, 2022

Benchmark runs are scheduled for baseline = caa6bf8 and contender = 2708c08. 2708c08 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.33% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.38% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2708c088 ec2-t3-xlarge-us-east-2
[Finished] 2708c088 test-mac-arm
[Finished] 2708c088 ursa-i9-9960x
[Finished] 2708c088 ursa-thinkcentre-m75q
[Finished] caa6bf87 ec2-t3-xlarge-us-east-2
[Failed] caa6bf87 test-mac-arm
[Finished] caa6bf87 ursa-i9-9960x
[Finished] caa6bf87 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants