Skip to content

MINOR: [Go][CI][Benchmarking] Fix GitHub info in Go benchmarks #14952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroshade merged 1 commit into from
Dec 14, 2022
Merged

MINOR: [Go][CI][Benchmarking] Fix GitHub info in Go benchmarks #14952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ci/scripts/go_bench_adapt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,17 @@

ARROW_ROOT = Path(__file__).parent.parent.parent.resolve()
SCRIPTS_PATH = ARROW_ROOT / "ci" / "scripts"
RUN_REASON = "commit" if os.environ.get("CONBENCH_REF") == "master" else "branch"

if os.environ.get("CONBENCH_REF") == "master":
Copy link
Member

@zeroshade zeroshade Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is CONBENCH_REF set in the workflow?

Copy link
Contributor Author

@austin3dickey austin3dickey Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here:

arrow/.github/workflows/go.yml

Line 91 in 794aefd

CONBENCH_REF: ${{ github.ref_name }}

github = {
"repository": os.environ["GITHUB_REPOSITORY"],
"commit": os.environ["GITHUB_SHA"],
"pr_number": None, # implying default branch
}
run_reason = "commit"
else:
github = None # scrape github info from the local repo
run_reason = "branch"

class GoAdapter(BenchmarkAdapter):
result_file = "bench_stats.json"
Expand Down Expand Up @@ -78,12 +88,8 @@ def _transform_results(self) -> List[BenchmarkResult]:
"name": pieces[0],
"params": '/'.join(pieces[1:]),
},
run_reason=RUN_REASON,
github={
"repository": os.environ["GITHUB_REPOSITORY"],
"commit": os.environ["GITHUB_SHA"],
"pr_number": None, # we currently only run this on the default branch
},
run_reason=run_reason,
github=github,
)
parsed.run_name = f"{parsed.run_reason}: {parsed.github['commit']}"
parsed_results.append(parsed)
Expand Down