Skip to content

Conversation

@assignUser
Copy link
Member

@assignUser assignUser commented Dec 13, 2022

The old variant with token passed as name does only work for classic PATS, passing the token as password works for both classic and fine grained PATs.

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #14927 has been automatically assigned in GitHub to PR creator.

@assignUser assignUser requested a review from raulcd December 13, 2022 13:27
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested myself. With my previous non-fine grained token I was able to submit a crossbow task with both using token as user and password.
With a new fine-grained token it only worked using the token as a password. Otherwise I got the following error:

archery.crossbow.core.CrossbowError: Wrong oauth personal access token

@raulcd raulcd merged commit 375372b into apache:master Dec 13, 2022
@ursabot
Copy link

ursabot commented Dec 14, 2022

Benchmark runs are scheduled for baseline = 84101a5 and contender = 375372b. 375372b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.1% ⬆️0.0%] test-mac-arm
[Finished ⬇️2.17% ⬆️1.09%] ursa-i9-9960x
[Finished ⬇️2.45% ⬆️1.05%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 375372b7 ec2-t3-xlarge-us-east-2
[Finished] 375372b7 test-mac-arm
[Finished] 375372b7 ursa-i9-9960x
[Finished] 375372b7 ursa-thinkcentre-m75q
[Finished] 84101a55 ec2-t3-xlarge-us-east-2
[Finished] 84101a55 test-mac-arm
[Finished] 84101a55 ursa-i9-9960x
[Finished] 84101a55 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Dec 14, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev] Crossbow submit does not work with fine grained PATs

3 participants