GH-14909: [Java] Prevent potential memory leak of ListSubfieldEncoder and StructSubfieldEncoder #14910
Conversation
gf2121
changed the title
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of old issues on JIRA the title also supports: See also: |
|
|
|
|
| try (final ListVector encoded = (ListVector) encoder.encodeListSubField(vector)) { | ||
| fail("There should be an exception when encoding"); | ||
| } catch (Exception e) { | ||
| assertEquals("Dictionary encoding not defined for value:" + 20, e.getMessage()); |
There was a problem hiding this comment.
nit: why concat here, when the string is fully hardcoded below?
| decoded.close(); | ||
| throw e; |
There was a problem hiding this comment.
Perhaps use AutoCloseables#close(Throwable, AutoCloseable...) for this kind of thing?
|
Benchmark runs are scheduled for baseline = 6f86fce and contender = c7eddff. c7eddff is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…ncoder and StructSubfieldEncoder (apache#14910) * Closes: apache#14909 Authored-by: 郭峰 <[email protected]> Signed-off-by: David Li <[email protected]>
3 participants
Uh oh!
There was an error while loading. Please reload this page.