GH-14876: [Go] Handling Crashes in C Data interface #14877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Dec 8, 2022
pitrou
reviewed
Dec 8, 2022
pitrou
reviewed
Dec 8, 2022
| for i := range arr.Data().Buffers() { | ||
| buf := arr.Data().Buffers()[i] | ||
| if buf == nil { | ||
| if buf == nil || buf.Len() == 0 { |
Member
There was a problem hiding this comment.
This doesn't seem mandatory either.
Member
Author
There was a problem hiding this comment.
The reason for this is line 374 below. In the case where buf.Len() == 0 there is no allocated data to grab a pointer to via &buf.Bytes()[0] and you end up panic'ing with an error of attempting to get index 0 of a 0 length slice. Thus if we create an empty array, it's better to just use a nil pointer.
The alternative here would be to use &buf.Buf()[0] instead, which points at the reserved bytes (since creating a new buffer will, by default, automatically reserve 64 bytes if it wasn't expanded) but I thought it better to not force us to keep that memory around for a 0 length array.
pitrou
reviewed
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.