-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-18421: [C++][ORC] Add accessor for stripe information in reader #14806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Why not expose the full stripe information? We don't want to create tons of little accessors for each different piece of information. |
|
Yes, why not. The offset is the number of bytes since the beginning of the file, in bytes, the length is the size of the stripe in bytes, num_rows is the number of rows in the stripe, and "first_row_of_strip" is the index of the first row in the stripe (thus the sum of the num_rows of all the preceding stripes). |
|
We can change it slightly and expose it as: struct StripeInformation {
int64_t offset;
int64_t length;
int64_t num_rows;
int64_t first_row_id;
};(note the use of signed integers to match our API conventions better) |
|
Ok, that seems fine to me. I will make the changes then. StripeInformation GetStripeInformation(int64_t stripe); |
|
Yes, that sounds fine. |
|
So this seems to be good now. I added the "StripeInformation" class in the header, and modified the implementation accordingly. |
pitrou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thank you @LouisClt
See https://issues.apache.org/jira/browse/ARROW-18421