Skip to content

ARROW-18264: [Python] Add missing value accessor to temporal types #14746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorisvandenbossche merged 4 commits into from
Dec 13, 2022
Merged

ARROW-18264: [Python] Add missing value accessor to temporal types #14746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06ad678
Add missing value to logical types
Nov 27, 2022
03b2552
Merge remote-tracking branch 'origin/master' into arrow-18264-python-…
Dec 5, 2022
a428800
Rename test function
Dec 5, 2022
9136dda
Merge remote-tracking branch 'origin/master' into arrow-18264-python-…
Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions python/pyarrow/scalar.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,11 @@ cdef class Date32Scalar(Scalar):
Concrete class for date32 scalars.
"""

@property
def value(self):
cdef CDate32Scalar* sp = <CDate32Scalar*> self.wrapped.get()
return sp.value if sp.is_valid else None

def as_py(self):
"""
Return this value as a Python datetime.datetime instance.
Expand All @@ -365,6 +370,11 @@ cdef class Date64Scalar(Scalar):
Concrete class for date64 scalars.
"""

@property
def value(self):
cdef CDate64Scalar* sp = <CDate64Scalar*> self.wrapped.get()
return sp.value if sp.is_valid else None

def as_py(self):
"""
Return this value as a Python datetime.datetime instance.
Expand Down
20 changes: 19 additions & 1 deletion python/pyarrow/tests/test_scalars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,32 @@ def test_time_from_datetime_time():
@pytest.mark.parametrize(['value', 'time_type'], [
(1, pa.time32("s")),
(2**30, pa.time32("s")),
(None, pa.time32("s")),
(1, pa.time32("ms")),
(2**30, pa.time32("ms")),
(None, pa.time32("ms")),
(1, pa.time64("us")),
(2**62, pa.time64("us")),
(None, pa.time64("us")),
(1, pa.time64("ns")),
(2**62, pa.time64("ns")),
(None, pa.time64("ns")),
(1, pa.date32()),
(2**30, pa.date32()),
(None, pa.date32()),
(1, pa.date64()),
(2**62, pa.date64()),
(None, pa.date64()),
(1, pa.timestamp("ns")),
(2**62, pa.timestamp("ns")),
(None, pa.timestamp("ns")),
(1, pa.duration("ns")),
(2**62, pa.duration("ns")),
(None, pa.duration("ns")),
((1, 2, -3), pa.month_day_nano_interval()),
(None, pa.month_day_nano_interval()),
])
def test_time_values(value, time_type):
def test_temporal_values(value, time_type: pa.DataType):
time_scalar = pa.scalar(value, type=time_type)
assert time_scalar.value == value

Expand Down