Skip to content

ARROW-1977: [C++] Update windows dev docs #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chris-b1 wants to merge 2 commits into from
Closed

ARROW-1977: [C++] Update windows dev docs #1466

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dab8b0
updates windows c++ env docs
Jan 8, 2018
0990ddc
remove python from cpp conda env
Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions cpp/apidoc/Windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ conda config --add channels conda-forge
Now, you can bootstrap a build environment

```shell
conda create -n arrow-dev cmake git boost-cpp flatbuffers rapidjson cmake thrift-cpp snappy zlib brotli gflags lz4-c zstd -c conda-forge
conda create -n arrow-dev python=3 cmake git boost-cpp flatbuffers rapidjson cmake thrift-cpp snappy zlib brotli gflags lz4-c zstd -c conda-forge

@wesm wesm Jan 8, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which dependency was causing Python to get installed? At least when these docs were written, none of these libraries had a Python dependency

@chris-b1 chris-b1 Jan 8, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can't actually reproduce this - I might have had an old version of conda installed or something - it definitely was picking up python 2.7, but with a clean Miniconda install isn't. I'll revert.

"C:\Users\chris.bartak\AppData\Local\Continuum\miniconda3\Scripts\conda.exe" create -n arrow-dev-test cmake git boost-cpp flatbuffers rapidjson cmake thrift-cpp snappy zlib brotli gflags lz4-c zstd -c conda-forge
Fetching package metadata ...............
Solving package specifications: .

Package plan for installation in environment C:\Users\chris.bartak\AppData\Local\Continuum\miniconda3\envs\arrow-dev-test:

The following NEW packages will be INSTALLED:

    boost-cpp:       1.66.0-vc14_1 conda-forge [vc14]
    brotli:          0.6.0-vc14_0  conda-forge [vc14]
    ca-certificates: 2017.11.5-0   conda-forge
    cmake:           3.10.0-4      conda-forge
    flatbuffers:     1.7.1-vc14_0  conda-forge [vc14]
    gflags:          2.2.0-vc14_1  conda-forge [vc14]
    git:             2.14.2-3      conda-forge
    lz4-c:           1.8.0-vc14_0  conda-forge [vc14]
    openssl:         1.0.2n-vc14_0 conda-forge [vc14]
    rapidjson:       1.1.0-0       conda-forge
    snappy:          1.1.7-vc14_1  conda-forge [vc14]
    thrift-cpp:      0.10.0-vc14_1 conda-forge [vc14]
    vc:              14-0          conda-forge
    vs2015_runtime:  14.0.25420-0  conda-forge
    zlib:            1.2.11-vc14_0 conda-forge [vc14]
    zstd:            1.3.2-vc14_1  conda-forge [vc14]

```

***Note:***
Expand All @@ -55,20 +55,16 @@ previous step:
activate arrow-dev
```

We are using [cmake][4] tool to support Windows builds.
We are using the [cmake][4] tool to support Windows builds.
To allow cmake to pick up 3rd party dependencies, you should set
`ARROW_BUILD_TOOLCHAIN` environment variable to contain `Library` folder
path of new created on previous step `arrow-dev` conda environment.
For instance, if `Miniconda` was installed to default destination, `Library`
folder path for `arrow-dev` conda environment will be as following:

To set `ARROW_BUILD_TOOLCHAIN` environment variable visible only for current terminal
session you can run following. `%CONDA_PREFIX` is set by conda to the current environment
root by the `activate` script.
```shell
C:\Users\YOUR_USER_NAME\Miniconda3\envs\arrow-dev\Library
```

To set `ARROW_BUILD_TOOLCHAIN` environment variable visible only for current terminal session you can run following:
```shell
set ARROW_BUILD_TOOLCHAIN=C:\Users\YOUR_USER_NAME\Miniconda3\envs\arrow-dev\Library
set ARROW_BUILD_TOOLCHAIN=%CONDA_PREFIX%\Library
```

To validate value of `ARROW_BUILD_TOOLCHAIN` environment variable you can run following terminal command:
Expand Down