Skip to content

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Nov 8, 2022

Unless there is a special reason, it is better to use docker.io/library/r-base, Docker Official Images.
It is built from the same source, but docker.io/library/r-base is always up-to-date because it is built automatically.

@raulcd
Copy link
Member

raulcd commented Nov 9, 2022

@assignUser @nealrichardson you might want to take a look on this one

@assignUser
Copy link
Member

It is maintained by the rocker community so they are probably updated pretty much at the same time. But the library/r-base image is a multich arch image which is actually a reason to switch. We would not be taking advantage of it immediatly but it should make it easier to test R stuff on different architectures.

image

@assignUser
Copy link
Member

@github-actions crossbow submit test-r-library-* test-r-minimal

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Revision: 0bbdc3d

Submitted crossbow builds: ursacomputing/crossbow @ actions-11872cebf2

Task Status
test-r-library-r-base-latest Azure
test-r-minimal-build Azure
test-r-offline-minimal Azure

@thisisnic
Copy link
Member

@assignUser Will this PR fix the problem alluded to here or do we still need to do something else?

@kou
Copy link
Member

kou commented Nov 16, 2022

This is not related to #14654 (comment) because this doesn't change dev/tasks/r/github.packages.yml.

@eitsupi
Copy link
Contributor Author

eitsupi commented Dec 6, 2022

@assignUser @kou Can you merge this? This is a really minor change.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 9b0f3d7 into apache:master Dec 6, 2022
@eitsupi eitsupi deleted the rocker-r-base branch December 6, 2022 22:07
@eitsupi
Copy link
Contributor Author

eitsupi commented Dec 6, 2022

Thanks!

@ursabot
Copy link

ursabot commented Dec 7, 2022

Benchmark runs are scheduled for baseline = 069a45f and contender = 9b0f3d7. 9b0f3d7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.17% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.31% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9b0f3d71 ec2-t3-xlarge-us-east-2
[Finished] 9b0f3d71 test-mac-arm
[Finished] 9b0f3d71 ursa-i9-9960x
[Finished] 9b0f3d71 ursa-thinkcentre-m75q
[Finished] 069a45f9 ec2-t3-xlarge-us-east-2
[Finished] 069a45f9 test-mac-arm
[Finished] 069a45f9 ursa-i9-9960x
[Finished] 069a45f9 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Dec 7, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants